Message ID | 20220722120224.2311982-4-berrange@redhat.com |
---|---|
State | New |
Headers | show |
Series | target: RFC: display deprecation flag for '-cpu help' | expand |
On Fri, Jul 22 2022, Daniel P. Berrangé <berrange@redhat.com> wrote: > When the user queries CPU models via QMP there is a 'deprecated' flag > present, however, this is not done for the CLI '-cpu help' command. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > target/arm/helper.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck <cohuck@redhat.com>
diff --git a/target/arm/helper.c b/target/arm/helper.c index 1a8b06410e..ef4e33f309 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8185,12 +8185,17 @@ static gint arm_cpu_list_compare(gconstpointer a, gconstpointer b) static void arm_cpu_list_entry(gpointer data, gpointer user_data) { ObjectClass *oc = data; + CPUClass *cc = CPU_CLASS(oc); const char *typename; char *name; typename = object_class_get_name(oc); name = g_strndup(typename, strlen(typename) - strlen("-" TYPE_ARM_CPU)); - qemu_printf(" %s\n", name); + if (cc->deprecation_note) { + qemu_printf(" %s (deprecated)\n", name); + } else { + qemu_printf(" %s\n", name); + } g_free(name); }
When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- target/arm/helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)