From patchwork Thu Jul 7 16:37:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 1653704 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MFHHe/wB; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lf2Lq2dfBz9s07 for ; Fri, 8 Jul 2022 02:44:35 +1000 (AEST) Received: from localhost ([::1]:49944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9UcC-00066H-59 for incoming@patchwork.ozlabs.org; Thu, 07 Jul 2022 12:44:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UVw-0008Sj-8i for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:59293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UVp-0006nk-CX for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657211874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SntZfyZnnODfKVkCXVO1fSkhca/EX/tEr2CvULvE+ms=; b=MFHHe/wByndJpGE1T/d6fv51+aynaDyxoqH7lCGL/HfixcV4DM7FpMpU+mqZxbr6dMxwLk HwYiQR2ItTnfwnIn/JObAGLIu8Id857SjQHdqANj/m6wK7FZSUAaHAHn2TU7/RUlUTX0Si UwvsL16G5ud06DbbDKcTwzDW34eiiEs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-StqnwGDHNxSepUoDNZ1DKQ-1; Thu, 07 Jul 2022 12:37:51 -0400 X-MC-Unique: StqnwGDHNxSepUoDNZ1DKQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6D86B1C1AD55; Thu, 7 Jul 2022 16:37:35 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id D43DE492C3B; Thu, 7 Jul 2022 16:37:33 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Blake , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Peter Maydell , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= Subject: [PATCH v3 7/9] tests/style: check qemu/osdep.h is included in all .c files Date: Thu, 7 Jul 2022 17:37:18 +0100 Message-Id: <20220707163720.1421716-8-berrange@redhat.com> In-Reply-To: <20220707163720.1421716-1-berrange@redhat.com> References: <20220707163720.1421716-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The qemu/osdep.h file must be included as the very first header in all C source files, to ensure its definitions take effect over all other header files, including system headers. Signed-off-by: Daniel P. Berrangé --- tests/style.yml | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tests/style.yml b/tests/style.yml index d06c55bb29..6d91ac6115 100644 --- a/tests/style.yml +++ b/tests/style.yml @@ -120,4 +120,26 @@ double_words: - pc-bios/ - qemu-options\.hx - scripts/checkpatch\.pl - - tests/qtest/arm-cpu-features\.c \ No newline at end of file + - tests/qtest/arm-cpu-features\.c + +osdep_h_in_source: + multiline: true + files: \.c$ + require: ^((?!#include)[^\n]*\n)*#include "qemu/osdep.h" + message: all C source files must include qemu/osdep.h, as the first header + ignore: + - contrib/plugins/.* + - linux-user/(mips64|x86_64)/(signal|cpu_loop)\.c + - pc-bios/.* + - scripts/coverity-scan/model\.c + - scripts/xen-detect\.c + - subprojects/.* + - target/hexagon/(gen_semantics|gen_dectree_import)\.c + - target/s390x/gen-features\.c + - tests/migration/s390x/a-b-bios\.c + - tests/multiboot/.* + - tests/plugin/.* + - tests/tcg/.* + - tests/uefi-test-tools/.* + - tests/unit/test-rcu-(simpleq|slist|tailq)\.c + - tools/ebpf/rss.bpf.c