From patchwork Mon Jul 4 15:22:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 1652066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ChTAHQyG; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lc8jJ09w6z9s5V for ; Tue, 5 Jul 2022 01:24:04 +1000 (AEST) Received: from localhost ([::1]:34254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Nvd-00056e-G6 for incoming@patchwork.ozlabs.org; Mon, 04 Jul 2022 11:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Nuu-000515-PB for qemu-devel@nongnu.org; Mon, 04 Jul 2022 11:23:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Nut-0002MH-BX for qemu-devel@nongnu.org; Mon, 04 Jul 2022 11:23:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656948194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a5v2G6lem/ZEC576JClSBjYZBfiuor+hY2xGADyGt3w=; b=ChTAHQyGAPYXW4KFeWoT4ALXwSJhV0eUKp4JZLqPdYgrG7ACsCSAS9UyFPzsaRpFKxg749 CGacBH17r1hpehNQkjjVwulMqjbAEWVtm/aLdisOhH/rYSpD+sINp7+toT3cdw1i549B5t 2+EDCummmcaVQtIn4Rqr+2BNNOHrgbo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-Tmb0p90DMkyGJY5AhEj8nA-1; Mon, 04 Jul 2022 11:23:13 -0400 X-MC-Unique: Tmb0p90DMkyGJY5AhEj8nA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA36E101A586; Mon, 4 Jul 2022 15:23:12 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36615C28100; Mon, 4 Jul 2022 15:23:11 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Daniel?= =?utf-8?q?_P=2E_Berrang=C3=A9?= Subject: [PATCH v2 3/7] tests/style: check for mixups of bool constants with int variables Date: Mon, 4 Jul 2022 16:22:59 +0100 Message-Id: <20220704152303.760983-4-berrange@redhat.com> In-Reply-To: <20220704152303.760983-1-berrange@redhat.com> References: <20220704152303.760983-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The 'true' and 'false' constants should only ever be used with the 'bool' type, never 'int'. Signed-off-by: Daniel P. Berrangé --- tests/style.mak | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/style.mak b/tests/style.mak index 32c7e706ba..ae658395c9 100644 --- a/tests/style.mak +++ b/tests/style.mak @@ -22,3 +22,9 @@ include tests/style-infra.mak include tests/style-excludes.mak + +# Use 'bool', not 'int', when assigning true or false +sc_int_assign_bool: + @prohibit='\.*= *(true|false)\b' \ + halt='use bool type for boolean values' \ + $(_sc_search_regexp)