| Message ID | 20220624160839.886649-1-mark.cave-ayland@ilande.co.uk |
|---|---|
| State | New |
| Headers | show |
| Series | artist: set memory region owners for buffers to the artist device | expand |
On 6/24/22 18:08, Mark Cave-Ayland wrote: > This fixes the output of "info qom-tree" so that the buffers appear as children > of the artist device, rather than underneath the "unattached" container. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Helge Deller <deller@gmx.de> Thanks! Helge > --- > hw/display/artist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/artist.c b/hw/display/artist.c > index eadaef0d46..fde050c882 100644 > --- a/hw/display/artist.c > +++ b/hw/display/artist.c > @@ -1358,7 +1358,7 @@ static void artist_create_buffer(ARTISTState *s, const char *name, > { > struct vram_buffer *buf = s->vram_buffer + idx; > > - memory_region_init_ram(&buf->mr, NULL, name, width * height, > + memory_region_init_ram(&buf->mr, OBJECT(s), name, width * height, > &error_fatal); > memory_region_add_subregion_overlap(&s->mem_as_root, *offset, &buf->mr, 0); >
On 26/06/2022 12:15, Helge Deller wrote: > On 6/24/22 18:08, Mark Cave-Ayland wrote: >> This fixes the output of "info qom-tree" so that the buffers appear as children >> of the artist device, rather than underneath the "unattached" container. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > > Reviewed-by: Helge Deller <deller@gmx.de> > > Thanks! > > Helge Thanks Helge. I'll queue this to my qemu-sparc branch along with the ps2 QOM patches given that it's a trivial patch, and I'm already touching the lasips2 device which requires testing the HPPA B160L machine anyhow. ATB, Mark.
diff --git a/hw/display/artist.c b/hw/display/artist.c index eadaef0d46..fde050c882 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -1358,7 +1358,7 @@ static void artist_create_buffer(ARTISTState *s, const char *name, { struct vram_buffer *buf = s->vram_buffer + idx; - memory_region_init_ram(&buf->mr, NULL, name, width * height, + memory_region_init_ram(&buf->mr, OBJECT(s), name, width * height, &error_fatal); memory_region_add_subregion_overlap(&s->mem_as_root, *offset, &buf->mr, 0);
This fixes the output of "info qom-tree" so that the buffers appear as children of the artist device, rather than underneath the "unattached" container. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> --- hw/display/artist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)