| Message ID | 20220526000921.1581503-4-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests, python: prepare to expand usage of test venv | expand |
On 5/26/22 02:09, John Snow wrote: > Use "python3" instead of "python" as per PEP0394: > https://peps.python.org/pep-0394/ > > This should always be defined (in a venv, at least!), matching the > preferred python shebang of "#!/usr/bin/env python3". > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 146aaa96a00..f68adda0650 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -89,7 +89,7 @@ TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, $(ninja-targets))) > TESTS_VENV_DIR=$(BUILD_DIR)/tests/venv > TESTS_VENV_REQ=$(SRC_PATH)/tests/requirements.txt > TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > -TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python > +TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python3 > ifndef AVOCADO_TESTS > AVOCADO_TESTS=tests/avocado > endif Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/tests/Makefile.include b/tests/Makefile.include index 146aaa96a00..f68adda0650 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -89,7 +89,7 @@ TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, $(ninja-targets))) TESTS_VENV_DIR=$(BUILD_DIR)/tests/venv TESTS_VENV_REQ=$(SRC_PATH)/tests/requirements.txt TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results -TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python +TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python3 ifndef AVOCADO_TESTS AVOCADO_TESTS=tests/avocado endif
Use "python3" instead of "python" as per PEP0394: https://peps.python.org/pep-0394/ This should always be defined (in a venv, at least!), matching the preferred python shebang of "#!/usr/bin/env python3". Signed-off-by: John Snow <jsnow@redhat.com> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)