Message ID | 20220427143541.119567-5-stefanha@redhat.com |
---|---|
State | New |
Headers | show |
Series | virtio-scsi: fix 100% CPU consumption in IOThread | expand |
On 4/27/22 16:35, Stefan Hajnoczi wrote: > virtio_scsi_handle_ctrl_vq() is only called from hw/scsi/virtio-scsi.c > now and its return value is no longer used. Remove the function > prototype from virtio-scsi.h and drop the return value. > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > include/hw/virtio/virtio-scsi.h | 1 - > hw/scsi/virtio-scsi.c | 5 +---- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h > index 5957597825..44dc3b81ec 100644 > --- a/include/hw/virtio/virtio-scsi.h > +++ b/include/hw/virtio/virtio-scsi.h > @@ -152,7 +152,6 @@ void virtio_scsi_common_realize(DeviceState *dev, > > void virtio_scsi_common_unrealize(DeviceState *dev); > bool virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq); > -bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq); > void virtio_scsi_init_req(VirtIOSCSI *s, VirtQueue *vq, VirtIOSCSIReq *req); > void virtio_scsi_free_req(VirtIOSCSIReq *req); > void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index aa03a713d8..eefda16e4b 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -460,16 +460,13 @@ static void virtio_scsi_handle_ctrl_req(VirtIOSCSI *s, VirtIOSCSIReq *req) > } > } > > -bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq) > +static void virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq) > { > VirtIOSCSIReq *req; > - bool progress = false; > > while ((req = virtio_scsi_pop_req(s, vq))) { > - progress = true; > virtio_scsi_handle_ctrl_req(s, req); > } > - return progress; > } > > /* Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index 5957597825..44dc3b81ec 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -152,7 +152,6 @@ void virtio_scsi_common_realize(DeviceState *dev, void virtio_scsi_common_unrealize(DeviceState *dev); bool virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq); -bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq); void virtio_scsi_init_req(VirtIOSCSI *s, VirtQueue *vq, VirtIOSCSIReq *req); void virtio_scsi_free_req(VirtIOSCSIReq *req); void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index aa03a713d8..eefda16e4b 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -460,16 +460,13 @@ static void virtio_scsi_handle_ctrl_req(VirtIOSCSI *s, VirtIOSCSIReq *req) } } -bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq) +static void virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq) { VirtIOSCSIReq *req; - bool progress = false; while ((req = virtio_scsi_pop_req(s, vq))) { - progress = true; virtio_scsi_handle_ctrl_req(s, req); } - return progress; } /*
virtio_scsi_handle_ctrl_vq() is only called from hw/scsi/virtio-scsi.c now and its return value is no longer used. Remove the function prototype from virtio-scsi.h and drop the return value. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- include/hw/virtio/virtio-scsi.h | 1 - hw/scsi/virtio-scsi.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-)