mbox

[PULL,for-7.0,0/2] Block patches

Message ID 20220317165743.238662-1-stefanha@redhat.com
State New
Headers show

Pull-request

https://gitlab.com/stefanha/qemu.git tags/block-pull-request

Message

Stefan Hajnoczi March 17, 2022, 4:57 p.m. UTC 
The following changes since commit 1d60bb4b14601e38ed17384277aa4c30c57925d3:

  Merge tag 'pull-request-2022-03-15v2' of https://gitlab.com/thuth/qemu into staging (2022-03-16 10:43:58 +0000)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to fc8796465c6cd4091efe6a2f8b353f07324f49c7:

  aio-posix: fix spurious ->poll_ready() callbacks in main loop (2022-03-17 11:23:18 +0000)

----------------------------------------------------------------
Pull request

Bug fixes for 7.0.

----------------------------------------------------------------

Haiyue Wang (1):
  aio-posix: fix build failure io_uring 2.2

Stefan Hajnoczi (1):
  aio-posix: fix spurious ->poll_ready() callbacks in main loop

 util/aio-posix.h      |  1 +
 util/aio-posix.c      | 32 ++++++++++++++++++--------------
 util/fdmon-io_uring.c |  4 ++++
 3 files changed, 23 insertions(+), 14 deletions(-)

Comments

Peter Maydell March 17, 2022, 6:36 p.m. UTC | #1 
On Thu, 17 Mar 2022 at 16:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 1d60bb4b14601e38ed17384277aa4c30c57925d3:
>
>   Merge tag 'pull-request-2022-03-15v2' of https://gitlab.com/thuth/qemu into staging (2022-03-16 10:43:58 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to fc8796465c6cd4091efe6a2f8b353f07324f49c7:
>
>   aio-posix: fix spurious ->poll_ready() callbacks in main loop (2022-03-17 11:23:18 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> Bug fixes for 7.0.

msys2-32bit CI job fails on test-aio:

| 14/85 ERROR:../tests/unit/test-aio.c:501:test_timer_schedule:
assertion failed: (aio_poll(ctx, true)) ERROR
14/85 qemu:unit / test-aio ERROR 2.40s (exit status 2147483651 or
signal 2147483523 SIGinvalid)

https://gitlab.com/qemu-project/qemu/-/jobs/2217696361

-- PMM
Stefan Hajnoczi March 21, 2022, 2:44 p.m. UTC | #2 
On Thu, Mar 17, 2022 at 06:36:36PM +0000, Peter Maydell wrote:
> On Thu, 17 Mar 2022 at 16:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit 1d60bb4b14601e38ed17384277aa4c30c57925d3:
> >
> >   Merge tag 'pull-request-2022-03-15v2' of https://gitlab.com/thuth/qemu into staging (2022-03-16 10:43:58 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to fc8796465c6cd4091efe6a2f8b353f07324f49c7:
> >
> >   aio-posix: fix spurious ->poll_ready() callbacks in main loop (2022-03-17 11:23:18 +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > Bug fixes for 7.0.
> 
> msys2-32bit CI job fails on test-aio:
> 
> | 14/85 ERROR:../tests/unit/test-aio.c:501:test_timer_schedule:
> assertion failed: (aio_poll(ctx, true)) ERROR
> 14/85 qemu:unit / test-aio ERROR 2.40s (exit status 2147483651 or
> signal 2147483523 SIGinvalid)
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/2217696361

Looks like a random failure. The commits touch Linux/POSIX code so I
don't know how this pull request could affect Windows.

I reran and the test passed:
https://gitlab.com/qemu-project/qemu/-/jobs/2229158826

Stefan
Peter Maydell March 21, 2022, 5:46 p.m. UTC | #3 
On Mon, 21 Mar 2022 at 14:44, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Thu, Mar 17, 2022 at 06:36:36PM +0000, Peter Maydell wrote:
> > On Thu, 17 Mar 2022 at 16:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > The following changes since commit 1d60bb4b14601e38ed17384277aa4c30c57925d3:
> > >
> > >   Merge tag 'pull-request-2022-03-15v2' of https://gitlab.com/thuth/qemu into staging (2022-03-16 10:43:58 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> > >
> > > for you to fetch changes up to fc8796465c6cd4091efe6a2f8b353f07324f49c7:
> > >
> > >   aio-posix: fix spurious ->poll_ready() callbacks in main loop (2022-03-17 11:23:18 +0000)
> > >
> > > ----------------------------------------------------------------
> > > Pull request
> > >
> > > Bug fixes for 7.0.
> >
> > msys2-32bit CI job fails on test-aio:
> >
> > | 14/85 ERROR:../tests/unit/test-aio.c:501:test_timer_schedule:
> > assertion failed: (aio_poll(ctx, true)) ERROR
> > 14/85 qemu:unit / test-aio ERROR 2.40s (exit status 2147483651 or
> > signal 2147483523 SIGinvalid)
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/2217696361
>
> Looks like a random failure. The commits touch Linux/POSIX code so I
> don't know how this pull request could affect Windows.

Seems like it.


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.0
for any user-visible changes.

-- PMM