| Message ID | 20220310171821.3724080-7-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: introduce testing coverage for TLS with migration | expand |
Daniel P. Berrangé <berrange@redhat.com> wrote: > The migration TLS code has a check mandating that a hostname be > available when starting a TLS session. This is expected when using > x509 credentials, but is bogus for PSK and anonymous credentials > as neither involve hostname validation. > > The TLS crdentials object gained suitable error reporting in the > case of TLS with x509 credentials, so there is no longer any need > for the migration code to do its own (incorrect) validation. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Should be safe for current one (famous last words).
diff --git a/migration/tls.c b/migration/tls.c index ca1ea3bbdd..32c384a8b6 100644 --- a/migration/tls.c +++ b/migration/tls.c @@ -137,10 +137,6 @@ QIOChannelTLS *migration_tls_client_create(MigrationState *s, if (s->parameters.tls_hostname && *s->parameters.tls_hostname) { hostname = s->parameters.tls_hostname; } - if (!hostname) { - error_setg(errp, "No hostname available for TLS"); - return NULL; - } tioc = qio_channel_tls_new_client( ioc, creds, hostname, errp);
The migration TLS code has a check mandating that a hostname be available when starting a TLS session. This is expected when using x509 credentials, but is bogus for PSK and anonymous credentials as neither involve hostname validation. The TLS crdentials object gained suitable error reporting in the case of TLS with x509 credentials, so there is no longer any need for the migration code to do its own (incorrect) validation. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- migration/tls.c | 4 ---- 1 file changed, 4 deletions(-)