| Message ID | 20211205224109.322152-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/avr: Realize AVRCPU qdev object using qdev_realize() | expand |
Reviewed-by: Michael Rolnik <mrolnik@gmail.com> On Mon, Dec 6, 2021 at 12:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. > TYPE_DEVICE instances are realized using qdev_realize(), we don't > need to access QOM internal values. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/avr/atmega.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c > index 0608e2d475e..a34803e6427 100644 > --- a/hw/avr/atmega.c > +++ b/hw/avr/atmega.c > @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error > **errp) > > /* CPU */ > object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type); > - object_property_set_bool(OBJECT(&s->cpu), "realized", true, > &error_abort); > + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort); > cpudev = DEVICE(&s->cpu); > > /* SRAM */ > -- > 2.33.1 > >
Hi Laurent, This patch is reviewed, can it go via your trivial tree? On 12/5/21 23:41, Philippe Mathieu-Daudé wrote: > TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. > TYPE_DEVICE instances are realized using qdev_realize(), we don't > need to access QOM internal values. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/avr/atmega.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c > index 0608e2d475e..a34803e6427 100644 > --- a/hw/avr/atmega.c > +++ b/hw/avr/atmega.c > @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp) > > /* CPU */ > object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type); > - object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort); > + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort); > cpudev = DEVICE(&s->cpu); > > /* SRAM */ >
Le 05/12/2021 à 23:41, Philippe Mathieu-Daudé a écrit : > TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. > TYPE_DEVICE instances are realized using qdev_realize(), we don't > need to access QOM internal values. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/avr/atmega.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c > index 0608e2d475e..a34803e6427 100644 > --- a/hw/avr/atmega.c > +++ b/hw/avr/atmega.c > @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp) > > /* CPU */ > object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type); > - object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort); > + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort); > cpudev = DEVICE(&s->cpu); > > /* SRAM */ > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c index 0608e2d475e..a34803e6427 100644 --- a/hw/avr/atmega.c +++ b/hw/avr/atmega.c @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp) /* CPU */ object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type); - object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort); + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort); cpudev = DEVICE(&s->cpu); /* SRAM */
TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. TYPE_DEVICE instances are realized using qdev_realize(), we don't need to access QOM internal values. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/avr/atmega.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)