| Message ID | 20211122104744.1051554-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/scsi: Fix scsi_bus_init_named() docstring | expand |
On Mon, 22 Nov 2021 at 10:47, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with > scsi_bus_init(), scsi_bus_init_named()") forgot to rename > scsi_bus_init() in the function documentation string. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/hw/scsi/scsi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h > index a567a5ed86b..2ef80af6dca 100644 > --- a/include/hw/scsi/scsi.h > +++ b/include/hw/scsi/scsi.h > @@ -158,7 +158,7 @@ struct SCSIBus { > * provided by the caller. It is the caller's responsibility to make > * sure that name does not clash with the name of any other bus in the > * system. Unless you need the new bus to have a specific name, you > - * should use scsi_bus_new() instead. > + * should use scsi_bus_init() instead. > */ > void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host, > const SCSIBusInfo *info, const char *bus_name); > -- > 2.31.1 Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Hi Laurent, This patch is reviewed, can it go via your trivial tree? On 11/22/21 11:47, Philippe Mathieu-Daudé wrote: > Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with > scsi_bus_init(), scsi_bus_init_named()") forgot to rename > scsi_bus_init() in the function documentation string. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/hw/scsi/scsi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h > index a567a5ed86b..2ef80af6dca 100644 > --- a/include/hw/scsi/scsi.h > +++ b/include/hw/scsi/scsi.h > @@ -158,7 +158,7 @@ struct SCSIBus { > * provided by the caller. It is the caller's responsibility to make > * sure that name does not clash with the name of any other bus in the > * system. Unless you need the new bus to have a specific name, you > - * should use scsi_bus_new() instead. > + * should use scsi_bus_init() instead. > */ > void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host, > const SCSIBusInfo *info, const char *bus_name); >
On 12/15/21 11:29, Philippe Mathieu-Daudé wrote: > Hi Laurent, > > This patch is reviewed, can it go via your trivial tree? Queued, thanks. Paolo > On 11/22/21 11:47, Philippe Mathieu-Daudé wrote: >> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with >> scsi_bus_init(), scsi_bus_init_named()") forgot to rename >> scsi_bus_init() in the function documentation string. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> include/hw/scsi/scsi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h >> index a567a5ed86b..2ef80af6dca 100644 >> --- a/include/hw/scsi/scsi.h >> +++ b/include/hw/scsi/scsi.h >> @@ -158,7 +158,7 @@ struct SCSIBus { >> * provided by the caller. It is the caller's responsibility to make >> * sure that name does not clash with the name of any other bus in the >> * system. Unless you need the new bus to have a specific name, you >> - * should use scsi_bus_new() instead. >> + * should use scsi_bus_init() instead. >> */ >> void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host, >> const SCSIBusInfo *info, const char *bus_name); >> >
diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index a567a5ed86b..2ef80af6dca 100644 --- a/include/hw/scsi/scsi.h +++ b/include/hw/scsi/scsi.h @@ -158,7 +158,7 @@ struct SCSIBus { * provided by the caller. It is the caller's responsibility to make * sure that name does not clash with the name of any other bus in the * system. Unless you need the new bus to have a specific name, you - * should use scsi_bus_new() instead. + * should use scsi_bus_init() instead. */ void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host, const SCSIBusInfo *info, const char *bus_name);
Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with scsi_bus_init(), scsi_bus_init_named()") forgot to rename scsi_bus_init() in the function documentation string. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/hw/scsi/scsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)