diff mbox series

[v2,4/4] MAINTAINERS: Agree to maintain nanoMIPS TCG frontend

Message ID 20211027041416.1237433-5-f4bug@amsat.org
State New
Headers show
Series MAINTAINERS: Sanitize 'MIPS TCG CPUs' section | expand

Commit Message

Philippe Mathieu-Daudé Oct. 27, 2021, 4:14 a.m. UTC
As of this commit, the nanoMIPS toolchains haven't been merged
in mainstream projects. However MediaTek provides a toolchain:
https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01

QEMU deprecation policy schedules code for removal. If we don't
need / want to remove, we should un-deprecated [*].

Since I now have spent more time with the ISA, I agree to maintain
it along with the other MIPS ISA. Therefore remove its deprecation
notice.

For historical notes, see commit a60442eb8 ("Deprecate nanoMIPS ISA").

[*] https://lore.kernel.org/qemu-devel/YVx7YGqUENP83vNF@redhat.com/

Cc: Vince Del Vecchio <Vince.DelVecchio@mediatek.com>
Cc: Petar Jovanovic <petar.jovanovic@syrmia.com>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: un-deprecate (danpb)
---
 docs/about/deprecated.rst | 23 -----------------------
 MAINTAINERS               |  6 +-----
 2 files changed, 1 insertion(+), 28 deletions(-)

Comments

Richard Henderson Oct. 28, 2021, 1:10 a.m. UTC | #1
On 10/26/21 9:14 PM, Philippe Mathieu-Daudé wrote:
> As of this commit, the nanoMIPS toolchains haven't been merged
> in mainstream projects. However MediaTek provides a toolchain:
> https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01
> 
> QEMU deprecation policy schedules code for removal. If we don't
> need / want to remove, we should un-deprecated [*].
> 
> Since I now have spent more time with the ISA, I agree to maintain
> it along with the other MIPS ISA. Therefore remove its deprecation
> notice.
> 
> For historical notes, see commit a60442eb8 ("Deprecate nanoMIPS ISA").
> 
> [*] https://lore.kernel.org/qemu-devel/YVx7YGqUENP83vNF@redhat.com/
> 
> Cc: Vince Del Vecchio <Vince.DelVecchio@mediatek.com>
> Cc: Petar Jovanovic <petar.jovanovic@syrmia.com>
> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Philippe Mathieu-Daudé Nov. 1, 2021, 11:44 a.m. UTC | #2
On 10/27/21 06:14, Philippe Mathieu-Daudé wrote:
> As of this commit, the nanoMIPS toolchains haven't been merged
> in mainstream projects. However MediaTek provides a toolchain:
> https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01
> 
> QEMU deprecation policy schedules code for removal. If we don't
> need / want to remove, we should un-deprecated [*].
> 
> Since I now have spent more time with the ISA, I agree to maintain
> it along with the other MIPS ISA. Therefore remove its deprecation
> notice.
> 
> For historical notes, see commit a60442eb8 ("Deprecate nanoMIPS ISA").
> 
> [*] https://lore.kernel.org/qemu-devel/YVx7YGqUENP83vNF@redhat.com/
> 
> Cc: Vince Del Vecchio <Vince.DelVecchio@mediatek.com>
> Cc: Petar Jovanovic <petar.jovanovic@syrmia.com>
> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: un-deprecate (danpb)
> ---
>  docs/about/deprecated.rst | 23 -----------------------
>  MAINTAINERS               |  6 +-----
>  2 files changed, 1 insertion(+), 28 deletions(-)

I tried to add nanoMIPS testing using the Codescape toolchain
suggested by MediaTek [*], unfortunately QEMU user-mode is not
able to run any nanoMIPS binary. Various pieces are missing.
In particular, mainstream QEMU doesn't implement the p32 ABI,
ELF binaries are handled as o32 and the syscall table doesn't
match anything correct.

I am sorry but I can not proceed further with this patch.

[*]
https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01
diff mbox series

Patch

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 0bed6ecb1da..5f4e4eeb2b0 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -246,13 +246,6 @@  System emulator CPUS
 ``Icelake-Client`` CPU Models are deprecated. Use ``Icelake-Server`` CPU
 Models instead.
 
-MIPS ``I7200`` CPU Model (since 5.2)
-''''''''''''''''''''''''''''''''''''
-
-The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
-(the ISA has never been upstreamed to a compiler toolchain). Therefore
-this CPU is also deprecated.
-
 
 QEMU API (QAPI) events
 ----------------------
@@ -342,13 +335,6 @@  The ``ppc64abi32`` architecture has a number of issues which regularly
 trip up our CI testing and is suspected to be quite broken. For that
 reason the maintainers strongly suspect no one actually uses it.
 
-MIPS ``I7200`` CPU (since 5.2)
-''''''''''''''''''''''''''''''
-
-The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
-(the ISA has never been upstreamed to a compiler toolchain). Therefore
-this CPU is also deprecated.
-
 Related binaries
 ----------------
 
@@ -380,12 +366,3 @@  point to a version that doesn't break runnability guarantees
 versions, aliases will point to newer CPU model versions
 depending on the machine type, so management software must
 resolve CPU model aliases before starting a virtual machine.
-
-Guest Emulator ISAs
--------------------
-
-nanoMIPS ISA
-''''''''''''
-
-The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
-As it is hard to generate binaries for it, declare it deprecated.
diff --git a/MAINTAINERS b/MAINTAINERS
index efcfa57cd6a..71b198139c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -237,14 +237,10 @@  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
 S: Odd Fixes
 F: target/mips/
 F: disas/mips.c
+X: disas/nanomips.*
 F: docs/system/cpu-models-mips.rst.inc
 F: tests/tcg/mips/
 
-MIPS TCG CPUs (nanoMIPS ISA)
-S: Orphan
-F: disas/nanomips.*
-F: target/mips/tcg/*nanomips*
-
 NiosII TCG CPUs
 M: Chris Wulff <crwulff@gmail.com>
 M: Marek Vasut <marex@denx.de>