diff mbox series

via-ide: Set user_creatable to false

Message ID 20211015092159.3E863748F57@zero.eik.bme.hu
State New
Headers show
Series via-ide: Set user_creatable to false | expand

Commit Message

BALATON Zoltan Oct. 15, 2021, 9:16 a.m. UTC 
This model only works as a function of the via superio chip not as a
standalone PCI device.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
This should be before the last patch changing via-ide or squshed into
it. And similar to usb part but there I need to add it to the info
struct. I can resend with these if you think this series worth the
hassle. The previous one fixing the usb irq works without this clean up.

 hw/ide/via.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Philippe Mathieu-Daudé Oct. 17, 2021, 4:19 p.m. UTC | #1 
On 10/15/21 11:16, BALATON Zoltan wrote:
> This model only works as a function of the via superio chip not as a
> standalone PCI device.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> This should be before the last patch changing via-ide or squshed into
> it. And similar to usb part but there I need to add it to the info
> struct. I can resend with these if you think this series worth the
> hassle. The previous one fixing the usb irq works without this clean up.
> 
>  hw/ide/via.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff mbox series

Patch

diff --git a/hw/ide/via.c b/hw/ide/via.c
index 252d18f4ac..82def819c4 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -217,6 +217,9 @@  static void via_ide_class_init(ObjectClass *klass, void *data)
 
     dc->reset = via_ide_reset;
     dc->vmsd = &vmstate_ide_pci;
+    /* Reason: only works as function of VIA southbridge */
+    dc->user_creatable = false;
+
     k->realize = via_ide_realize;
     k->exit = via_ide_exitfn;
     k->vendor_id = PCI_VENDOR_ID_VIA;