diff mbox series

[3/3] hw/char: sifive_uart: Register device in 'input' category

Message ID 20210926105003.2716-3-bmeng.cn@gmail.com
State New
Headers show
Series [1/3] hw/char: ibex_uart: Register device in 'input' category | expand

Commit Message

Bin Meng Sept. 26, 2021, 10:50 a.m. UTC
The category of sifive_uart device is not set. Put it into the
'input' category.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 hw/char/sifive_uart.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé Sept. 26, 2021, 2:40 p.m. UTC | #1
On 9/26/21 12:50, Bin Meng wrote:
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  hw/char/sifive_uart.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Alistair Francis Sept. 28, 2021, 6:54 a.m. UTC | #2
On Sun, Sep 26, 2021 at 8:53 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
>  hw/char/sifive_uart.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
> index 278e21c434..1c75f792b3 100644
> --- a/hw/char/sifive_uart.c
> +++ b/hw/char/sifive_uart.c
> @@ -248,6 +248,7 @@ static void sifive_uart_class_init(ObjectClass *oc, void *data)
>      rc->phases.enter = sifive_uart_reset_enter;
>      rc->phases.hold  = sifive_uart_reset_hold;
>      device_class_set_props(dc, sifive_uart_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>
>  static const TypeInfo sifive_uart_info = {
> --
> 2.25.1
>
>
Alistair Francis Sept. 28, 2021, 9:18 a.m. UTC | #3
On Sun, Sep 26, 2021 at 8:53 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>
>  hw/char/sifive_uart.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
> index 278e21c434..1c75f792b3 100644
> --- a/hw/char/sifive_uart.c
> +++ b/hw/char/sifive_uart.c
> @@ -248,6 +248,7 @@ static void sifive_uart_class_init(ObjectClass *oc, void *data)
>      rc->phases.enter = sifive_uart_reset_enter;
>      rc->phases.hold  = sifive_uart_reset_hold;
>      device_class_set_props(dc, sifive_uart_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>
>  static const TypeInfo sifive_uart_info = {
> --
> 2.25.1
>
>
diff mbox series

Patch

diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
index 278e21c434..1c75f792b3 100644
--- a/hw/char/sifive_uart.c
+++ b/hw/char/sifive_uart.c
@@ -248,6 +248,7 @@  static void sifive_uart_class_init(ObjectClass *oc, void *data)
     rc->phases.enter = sifive_uart_reset_enter;
     rc->phases.hold  = sifive_uart_reset_hold;
     device_class_set_props(dc, sifive_uart_properties);
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
 }
 
 static const TypeInfo sifive_uart_info = {