| Message ID | 20210908185338.7927-1-jziviani@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | tcg/arm: Fix tcg_out_vec_op function signature | expand |
On 9/8/21 8:53 PM, Jose R. Ziviani wrote: > Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op > for arm is missing. It causes a build error on armv6 and armv7: > > tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *' > {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=] > const TCGArg *args, const int *const_args) > ~~~~~~~~~~~~~~^~~~ > ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]' > {aka 'const unsigned int[16]'} > const TCGArg args[TCG_MAX_OP_ARGS], > ~~~~~~~~~~~~~~^~~~ > > Signed-off-by: Jose R. Ziviani <jziviani@suse.de> > --- > tcg/arm/tcg-target.c.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc > index 007ceee68e..e5b4f86841 100644 > --- a/tcg/arm/tcg-target.c.inc > +++ b/tcg/arm/tcg-target.c.inc > @@ -2715,7 +2715,8 @@ static const ARMInsn vec_cmp0_insn[16] = { > > static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, > unsigned vecl, unsigned vece, > - const TCGArg *args, const int *const_args) > + const TCGArg args[TCG_MAX_OP_ARGS], > + const int const_args[TCG_MAX_OP_ARGS]) > { > TCGType type = vecl + TCG_TYPE_V64; > unsigned q = vecl; > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 9/8/21 8:53 PM, Jose R. Ziviani wrote: > Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op > for arm is missing. It causes a build error on armv6 and armv7: > > tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *' > {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=] > const TCGArg *args, const int *const_args) > ~~~~~~~~~~~~~~^~~~ > ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]' > {aka 'const unsigned int[16]'} > const TCGArg args[TCG_MAX_OP_ARGS], > ~~~~~~~~~~~~~~^~~~ > > Signed-off-by: Jose R. Ziviani<jziviani@suse.de> > --- > tcg/arm/tcg-target.c.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Queued, thanks. r~
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 007ceee68e..e5b4f86841 100644 --- a/tcg/arm/tcg-target.c.inc +++ b/tcg/arm/tcg-target.c.inc @@ -2715,7 +2715,8 @@ static const ARMInsn vec_cmp0_insn[16] = { static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, unsigned vecl, unsigned vece, - const TCGArg *args, const int *const_args) + const TCGArg args[TCG_MAX_OP_ARGS], + const int const_args[TCG_MAX_OP_ARGS]) { TCGType type = vecl + TCG_TYPE_V64; unsigned q = vecl;
Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op for arm is missing. It causes a build error on armv6 and armv7: tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *' {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=] const TCGArg *args, const int *const_args) ~~~~~~~~~~~~~~^~~~ ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]' {aka 'const unsigned int[16]'} const TCGArg args[TCG_MAX_OP_ARGS], ~~~~~~~~~~~~~~^~~~ Signed-off-by: Jose R. Ziviani <jziviani@suse.de> --- tcg/arm/tcg-target.c.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)