| Message ID | 20210906170038.26602-1-hreitz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [qemu-web,RFC] CONTRIBUTING.md: Mention maintainers | expand |
On 06/09/21 19:00, Hanna Reitz wrote: > This is an RFC first because I feel bad about sending a patch that > gives people responsibilities who aren't me. But Thomas seemed to agree > with me that making this requirement explicit would be nice, so I guess > someone has to send a patch for it... Don't feel bad, I'll make sure you'll have to send a v2. Actually I'm kidding, this looks good to me and I've merged it. But we should make a decision on accepting qemu-web merge requests on GitLab. For that, apart from touching the CONTRIBUTING.md file, we should also edit https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which suggests using "git send-email". Paolo > Second, I'm not sure whether this is the ideal place. Perhaps we should > have a MAINTAINERS file, but on the other hand, maybe that would be a > bit too much. > --- > CONTRIBUTING.md | 5 +++++ > 1 file changed, 5 insertions(+)
On 07/09/2021 14.57, Paolo Bonzini wrote: > On 06/09/21 19:00, Hanna Reitz wrote: >> This is an RFC first because I feel bad about sending a patch that >> gives people responsibilities who aren't me. But Thomas seemed to agree >> with me that making this requirement explicit would be nice, so I guess >> someone has to send a patch for it... > > Don't feel bad, I'll make sure you'll have to send a v2. Actually I'm > kidding, this looks good to me and I've merged it. Yes, that was a good idea. Ack from my side, too. > But we should make a decision on accepting qemu-web merge requests on > GitLab. For that, apart from touching the CONTRIBUTING.md file, we should > also edit https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which > suggests using "git send-email". Not sure whether that old blog post is the right place for this information ... we should maybe have a pointer to the information on https://www.qemu.org/contribute/ instead? Thomas
On 07.09.21 14:57, Paolo Bonzini wrote: > On 06/09/21 19:00, Hanna Reitz wrote: >> This is an RFC first because I feel bad about sending a patch that >> gives people responsibilities who aren't me. But Thomas seemed to agree >> with me that making this requirement explicit would be nice, so I guess >> someone has to send a patch for it... > > Don't feel bad, I'll make sure you'll have to send a v2. Well, as long as you aren’t asking me to take responsibility so I could feel less bad... > Actually I'm kidding, this looks good to me and I've merged it. Thanks! > But we should make a decision on accepting qemu-web merge requests on > GitLab. For that, apart from touching the CONTRIBUTING.md file, we > should also edit > https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ which > suggests using "git send-email". Well, it’s definitely not my decision to make, but FWIW I’m in favor. Hanna
On 07/09/21 15:40, Thomas Huth wrote: > we should maybe have a pointer to the information on > https://www.qemu.org/contribute/ instead? Yes - right now contribute/ links to the old blog post for "Improve the web site", but I guess it couuld just go to https://gitlab.com/qemu-project/qemu-web/-/merge_requests; "whoever has ears, let them hear". Paolo
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b5209ac..d5cbf07 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,11 @@ the the developer mailing list: https://lists.nongnu.org/mailman/listinfo/qemu-devel +You should also CC the website maintainers: + +* Thomas Huth <thuth@redhat.com> +* Paolo Bonzini <pbonzini@redhat.com> + For further guidance on sending patches consult: https://wiki.qemu.org/Contribute/SubmitAPatch
All patches to the QEMU website should be CC-ed to the website maintainers, who (right now) are Thomas and Paolo. Signed-off-by: Hanna Reitz <hreitz@redhat.com> --- This is an RFC first because I feel bad about sending a patch that gives people responsibilities who aren't me. But Thomas seemed to agree with me that making this requirement explicit would be nice, so I guess someone has to send a patch for it... Second, I'm not sure whether this is the ideal place. Perhaps we should have a MAINTAINERS file, but on the other hand, maybe that would be a bit too much. --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+)