Message ID | 20210615133855.775687-8-pbonzini@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=q9f6QEGO; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G48mp6WFBz9sWw for <incoming@patchwork.ozlabs.org>; Tue, 15 Jun 2021 23:48:58 +1000 (AEST) Received: from localhost ([::1]:32980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1lt9R2-0006Ef-I3 for incoming@patchwork.ozlabs.org; Tue, 15 Jun 2021 09:48:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <paolo.bonzini@gmail.com>) id 1lt9Hb-0005e3-1S for qemu-devel@nongnu.org; Tue, 15 Jun 2021 09:39:11 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:36673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <paolo.bonzini@gmail.com>) id 1lt9HU-0002g6-9T for qemu-devel@nongnu.org; Tue, 15 Jun 2021 09:39:07 -0400 Received: by mail-ej1-x629.google.com with SMTP id nd37so14903507ejc.3 for <qemu-devel@nongnu.org>; Tue, 15 Jun 2021 06:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f14dpNn0/J+5dS2KxNQSZZBoi/TEgJbxNaHvHTAG8hM=; b=q9f6QEGOAe5dUT8ismLN81WkjxLIsCAzJkY/s/1ihKgVhv9dLjYHGGFZu609AQYqym oBZA3iYPnz8A/Rx6ungK6Ccb2DG7zUMWjUf2b524lqO1lBhL/XYhnr7ybEkKiBVOUvyx 9EUDQWzdjcrZA1Q4vumViqq9QpiqvPQl23rSXOQOdKW/Pv2Ksx8zFE/ApjBnXOSX1CUs yJEKyLgyxyHIjg1d3B5BdVtD+bRmHk17sJykqxjp9U8buihbO6S/g0V8RWTmUN9gzKc8 PLnJb9e+5FSJl2ot+46RhnHL34xgSjl6dhjtLb0yEdOOhKzNKXebN9+ZGwwD+WhZfzqo 3DgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=f14dpNn0/J+5dS2KxNQSZZBoi/TEgJbxNaHvHTAG8hM=; b=EKjjUXsbll/E2uzbvd6vQHbzGdLMDeLNc2Rzu4TWiC21Q72V1sD3vcfzwMRdQKhHHt YCNH3VCRcgbLHgmw0v0Rspa7pZSho2rU1GclmlCNEAj+VTqqO4uHzh2samRbPPGcd4sn s+b3Osz9ZOTFG/BbSdR52LSypqRjFcKNyFfINvkW8flnQ0ro5t8P1aas69bgZqyAg5o4 KKFNIu/2AcWQCY8FGviAmRBNKJV8XzzGipdAdwltj0lYoJZlIzcJ2ZTGOBHib79j/OT7 Ap7AiEtvs0rIqpO6O9JIi6Lt8sNRqfmCPzMDZiN++IhfCvSMgLDmx5tQkFJn3XZxU9o+ ZrBw== X-Gm-Message-State: AOAM532PACldgYklQetJ0feW0HO0hmrL+EgfvyCLgfuFVymUAF4GF6/A WKhhrI9iUEB3lLhuJMb2z4L7swMRP6s= X-Google-Smtp-Source: ABdhPJz1lSAD3Ts/+py85pv8OII5/WBREiLCGMg2tr97K7av9XQwMN6IK42Op45RtGnqKGmiMf9/Lg== X-Received: by 2002:a17:907:7b9d:: with SMTP id ne29mr21513077ejc.167.1623764342613; Tue, 15 Jun 2021 06:39:02 -0700 (PDT) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id r17sm11843769edt.33.2021.06.15.06.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 06:39:02 -0700 (PDT) From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Subject: [PULL 07/33] esp: only set ESP_RSEQ at the start of the select sequence Date: Tue, 15 Jun 2021 15:38:29 +0200 Message-Id: <20210615133855.775687-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615133855.775687-1-pbonzini@redhat.com> References: <20210615133855.775687-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=paolo.bonzini@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,01/33] vnc: avoid deprecation warnings for SASL on OS X
|
expand
|
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 000e45a624..18d4d56392 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -481,7 +481,6 @@ static void esp_dma_done(ESPState *s) { s->rregs[ESP_RSTAT] |= STAT_TC; s->rregs[ESP_RINTR] |= INTR_BS; - s->rregs[ESP_RSEQ] = 0; s->rregs[ESP_RFLAGS] = 0; esp_set_tc(s, 0); esp_raise_irq(s); @@ -917,7 +916,15 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr) val = s->rregs[ESP_RINTR]; s->rregs[ESP_RINTR] = 0; s->rregs[ESP_RSTAT] &= ~STAT_TC; - s->rregs[ESP_RSEQ] = SEQ_0; + /* + * According to the datasheet ESP_RSEQ should be cleared, but as the + * emulation currently defers information transfers to the next TI + * command leave it for now so that pedantic guests such as the old + * Linux 2.6 driver see the correct flags before the next SCSI phase + * transition. + * + * s->rregs[ESP_RSEQ] = SEQ_0; + */ esp_lower_irq(s); break; case ESP_TCHI: