| Message ID | 20210507144315.1994337-15-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | misc: Replace alloca() by g_malloc() | expand |
On 5/7/21 4:43 PM, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Use autofree heap allocation instead, replacing g_newa() by g_new(). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> > --- > hw/misc/pca9552.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c > index b7686e27d7f..facf103cbfb 100644 > --- a/hw/misc/pca9552.c > +++ b/hw/misc/pca9552.c > @@ -71,7 +71,7 @@ static void pca955x_display_pins_status(PCA955xState *s, > return; > } > if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) { > - char *buf = g_newa(char, k->pin_count + 1); > + g_autofree char *buf = g_new(char, k->pin_count + 1); > > for (i = 0; i < k->pin_count; i++) { > if (extract32(pins_status, i, 1)) { >
diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index b7686e27d7f..facf103cbfb 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -71,7 +71,7 @@ static void pca955x_display_pins_status(PCA955xState *s, return; } if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) { - char *buf = g_newa(char, k->pin_count + 1); + g_autofree char *buf = g_new(char, k->pin_count + 1); for (i = 0; i < k->pin_count; i++) { if (extract32(pins_status, i, 1)) {
The ALLOCA(3) man-page mentions its "use is discouraged". Use autofree heap allocation instead, replacing g_newa() by g_new(). Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/misc/pca9552.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)