diff mbox series

[PULL,06/25] qapi/expr.py: move string check upwards in check_type

Message ID 20210430114838.2912740-7-armbru@redhat.com
State New
Headers show
Series [PULL,01/25] qapi/expr: Comment cleanup | expand

Commit Message

Markus Armbruster April 30, 2021, 11:48 a.m. UTC
From: John Snow <jsnow@redhat.com>

For readability purposes only, shimmy the early return upwards to the
top of the function, so cases proceed in order from least to most

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210421182032.3521476-7-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
 scripts/qapi/expr.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff mbox series


diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 3ab78a555d..c0d18dcc01 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -171,6 +171,10 @@  def check_type(value, info, source,
     if value is None:
+    # Type name
+    if isinstance(value, str):
+        return
     # Array type
     if isinstance(value, list):
         if not allow_array:
@@ -181,10 +185,6 @@  def check_type(value, info, source,
-    # Type name
-    if isinstance(value, str):
-        return
     # Anonymous type
     if not allow_dict: