diff mbox series

[PULL,08/10] mirror: Do not enter a paused job on completion

Message ID 20210409161548.341297-9-kwolf@redhat.com
State New
Headers show
Series [PULL,01/10] block/rbd: fix memory leak in qemu_rbd_connect() | expand

Commit Message

Kevin Wolf April 9, 2021, 4:15 p.m. UTC
From: Max Reitz <mreitz@redhat.com>

Currently, it is impossible to complete jobs on standby (i.e. paused
ready jobs), but actually the only thing in mirror_complete() that does
not work quite well with a paused job is the job_enter() at the end.

If we make it conditional, this function works just fine even if the
mirror job is paused.

So technically this is a no-op, but obviously the intention is to accept
block-job-complete even for jobs on standby, which we need this patch
for first.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210409120422.144040-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
 block/mirror.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/block/mirror.c b/block/mirror.c
index f1f936bf1a..5a71bd8bbc 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1148,7 +1148,11 @@  static void mirror_complete(Job *job, Error **errp)
     s->should_complete = true;
-    job_enter(job);
+    /* If the job is paused, it will be re-entered when it is resumed */
+    if (!job->paused) {
+        job_enter(job);
+    }
 static void coroutine_fn mirror_pause(Job *job)