diff mbox series

[v3,1/2] iotests/231: Update expected deprecation message

Message ID 20210409143854.138177-2-ckuehl@redhat.com
State New
Headers show
Series Fix segfault in qemu_rbd_parse_filename | expand

Commit Message

Connor Kuehl April 9, 2021, 2:38 p.m. UTC
The deprecation message in the expected output has technically been
wrong since the wrong version of a patch was applied to it. Because of
this, the test fails. Correct the expected output so that it passes.

Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/231.out | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stefano Garzarella April 21, 2021, 10:48 a.m. UTC | #1
On Fri, Apr 09, 2021 at 09:38:53AM -0500, Connor Kuehl wrote:
>The deprecation message in the expected output has technically been
>wrong since the wrong version of a patch was applied to it. Because of
>this, the test fails. Correct the expected output so that it passes.
>
>Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
>Reviewed-by: Max Reitz <mreitz@redhat.com>
>---
> tests/qemu-iotests/231.out | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/tests/qemu-iotests/231.out b/tests/qemu-iotests/231.out
>index 579ba11c16..747dd221bb 100644
>--- a/tests/qemu-iotests/231.out
>+++ b/tests/qemu-iotests/231.out
>@@ -1,9 +1,7 @@
> QA output created by 231
>-qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated.  Future versions may cease to parse these options in the future.
>+qemu-img: warning: RBD options encoded in the filename as keyvalue pairs is deprecated
> unable to get monitor info from DNS SRV with service name: ceph-mon
>-no monitors specified to connect to.
> qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory
> unable to get monitor info from DNS SRV with service name: ceph-mon
>-no monitors specified to connect to.
> qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory
> *** done
>-- 
>2.30.2
>
>
diff mbox series

Patch

diff --git a/tests/qemu-iotests/231.out b/tests/qemu-iotests/231.out
index 579ba11c16..747dd221bb 100644
--- a/tests/qemu-iotests/231.out
+++ b/tests/qemu-iotests/231.out
@@ -1,9 +1,7 @@ 
 QA output created by 231
-qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated.  Future versions may cease to parse these options in the future.
+qemu-img: warning: RBD options encoded in the filename as keyvalue pairs is deprecated
 unable to get monitor info from DNS SRV with service name: ceph-mon
-no monitors specified to connect to.
 qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory
 unable to get monitor info from DNS SRV with service name: ceph-mon
-no monitors specified to connect to.
 qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory
 *** done