Message ID | 20210329170818.23139-1-bmeng.cn@gmail.com |
---|---|
State | Superseded |
Headers | show |
Series | [1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper | expand |
On Mon, Mar 29, 2021 at 1:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array helper"), > we can use the new helper to set the clock name for the ethernet > controller node. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/sifive_u.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c > index 7b59942369..f06b3b2e64 100644 > --- a/hw/riscv/sifive_u.c > +++ b/hw/riscv/sifive_u.c > @@ -96,7 +96,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > int cpu; > uint32_t *cells; > char *nodename; > - char ethclk_names[] = "pclk\0hclk"; > + const char *ethclk_names[2] = { "pclk", "hclk" }; > uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle = 1; > uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle; > > @@ -413,8 +413,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > qemu_fdt_setprop_cell(fdt, nodename, "interrupts", SIFIVE_U_GEM_IRQ); > qemu_fdt_setprop_cells(fdt, nodename, "clocks", > prci_phandle, PRCI_CLK_GEMGXLPLL, prci_phandle, PRCI_CLK_GEMGXLPLL); > - qemu_fdt_setprop(fdt, nodename, "clock-names", ethclk_names, > - sizeof(ethclk_names)); > + qemu_fdt_setprop_string_array(fdt, nodename, "clock-names", > + (char **)ðclk_names, ARRAY_SIZE(ethclk_names)); > qemu_fdt_setprop(fdt, nodename, "local-mac-address", > s->soc.gem.conf.macaddr.a, ETH_ALEN); > qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", 1); > -- > 2.25.1 > >
On 3/29/21 10:08 AM, Bin Meng wrote: > - char ethclk_names[] = "pclk\0hclk"; > + const char *ethclk_names[2] = { "pclk", "hclk" }; static const char * const ethclk_names[2] r~
diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 7b59942369..f06b3b2e64 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -96,7 +96,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, int cpu; uint32_t *cells; char *nodename; - char ethclk_names[] = "pclk\0hclk"; + const char *ethclk_names[2] = { "pclk", "hclk" }; uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle = 1; uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle; @@ -413,8 +413,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, qemu_fdt_setprop_cell(fdt, nodename, "interrupts", SIFIVE_U_GEM_IRQ); qemu_fdt_setprop_cells(fdt, nodename, "clocks", prci_phandle, PRCI_CLK_GEMGXLPLL, prci_phandle, PRCI_CLK_GEMGXLPLL); - qemu_fdt_setprop(fdt, nodename, "clock-names", ethclk_names, - sizeof(ethclk_names)); + qemu_fdt_setprop_string_array(fdt, nodename, "clock-names", + (char **)ðclk_names, ARRAY_SIZE(ethclk_names)); qemu_fdt_setprop(fdt, nodename, "local-mac-address", s->soc.gem.conf.macaddr.a, ETH_ALEN); qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", 1);