| Message ID | 20210323221539.3532660-7-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Test: introduce base class for Linux based tests | expand |
On Wed, Mar 24, 2021 at 2:21 AM Cleber Rosa <crosa@redhat.com> wrote: > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > tests/acceptance/avocado_qemu/__init__.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/acceptance/avocado_qemu/__init__.py > b/tests/acceptance/avocado_qemu/__init__.py > index e75b002c70..535f63a48d 100644 > --- a/tests/acceptance/avocado_qemu/__init__.py > +++ b/tests/acceptance/avocado_qemu/__init__.py > @@ -308,6 +308,8 @@ class LinuxTest(Test, LinuxSSHMixIn): > > timeout = 900 > chksum = None > + username = 'root' > + password = 'password' > > def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'): > super(LinuxTest, self).setUp() > @@ -370,8 +372,8 @@ def prepare_cloudinit(self, ssh_pubkey=None): > with open(ssh_pubkey) as pubkey: > pubkey_content = pubkey.read() > cloudinit.iso(cloudinit_iso, self.name, > - username='root', > - password='password', > + username=self.username, > + password=self.password, > # QEMU's hard coded usermode router address > phone_home_host='10.0.2.2', > phone_home_port=self.phone_home_port, > -- > 2.25.4 > > >
On 3/23/21 11:15 PM, Cleber Rosa wrote: > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > tests/acceptance/avocado_qemu/__init__.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py > index e75b002c70..535f63a48d 100644 > --- a/tests/acceptance/avocado_qemu/__init__.py > +++ b/tests/acceptance/avocado_qemu/__init__.py > @@ -308,6 +308,8 @@ class LinuxTest(Test, LinuxSSHMixIn): > > timeout = 900 > chksum = None > + username = 'root' > + password = 'password' > > def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'): > super(LinuxTest, self).setUp() > @@ -370,8 +372,8 @@ def prepare_cloudinit(self, ssh_pubkey=None): > with open(ssh_pubkey) as pubkey: > pubkey_content = pubkey.read() > cloudinit.iso(cloudinit_iso, self.name, > - username='root', > - password='password', > + username=self.username, > + password=self.password, > # QEMU's hard coded usermode router address > phone_home_host='10.0.2.2', > phone_home_port=self.phone_home_port, >
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa <crosa@redhat.com> wrote: > > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/avocado_qemu/__init__.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index e75b002c70..535f63a48d 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -308,6 +308,8 @@ class LinuxTest(Test, LinuxSSHMixIn): timeout = 900 chksum = None + username = 'root' + password = 'password' def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'): super(LinuxTest, self).setUp() @@ -370,8 +372,8 @@ def prepare_cloudinit(self, ssh_pubkey=None): with open(ssh_pubkey) as pubkey: pubkey_content = pubkey.read() cloudinit.iso(cloudinit_iso, self.name, - username='root', - password='password', + username=self.username, + password=self.password, # QEMU's hard coded usermode router address phone_home_host='10.0.2.2', phone_home_port=self.phone_home_port,
This makes the username/password used for authentication configurable, because some guest operating systems may have restrictions on accounts to be used for logins, and it just makes it better documented. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/avocado_qemu/__init__.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)