| Message ID | 20210306060152.7250-1-bmeng.cn@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] hw/block: m25p80: Support fast read for SST flashes | expand |
On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after > the address bytes. Note only SPI mode is supported by SST flashes. > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Acked-by: Alistair Francis <alistair.francis@wdc.com> > > --- > > Changes in v2: > - rebase on qemu/master > > hw/block/m25p80.c | 3 +++ > 1 file changed, 3 insertions(+) > Ping?
On Thu, Mar 11, 2021 at 4:18 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > From: Bin Meng <bin.meng@windriver.com> > > > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after > > the address bytes. Note only SPI mode is supported by SST flashes. > > > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf > > > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > > Acked-by: Alistair Francis <alistair.francis@wdc.com> > > > > --- > > > > Changes in v2: > > - rebase on qemu/master > > > > hw/block/m25p80.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Ping? Ping?
On Tue, Mar 16, 2021 at 9:39 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Thu, Mar 11, 2021 at 4:18 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > > > From: Bin Meng <bin.meng@windriver.com> > > > > > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after > > > the address bytes. Note only SPI mode is supported by SST flashes. > > > > > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf > > > > > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > > > Acked-by: Alistair Francis <alistair.francis@wdc.com> > > > > > > --- > > > > > > Changes in v2: > > > - rebase on qemu/master > > > > > > hw/block/m25p80.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > > Ping? > > Ping? Ping?
On Sat, Mar 6, 2021 at 1:02 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after > the address bytes. Note only SPI mode is supported by SST flashes. > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Acked-by: Alistair Francis <alistair.francis@wdc.com> Thanks! Applied to riscv-to-apply.next Alistair > > --- > > Changes in v2: > - rebase on qemu/master > > hw/block/m25p80.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 5f9471d83c..183d3f44c2 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -895,6 +895,9 @@ static void decode_fast_read_cmd(Flash *s) > s->needed_bytes = get_addr_length(s); > switch (get_man(s)) { > /* Dummy cycles - modeled with bytes writes instead of bits */ > + case MAN_SST: > + s->needed_bytes += 1; > + break; > case MAN_WINBOND: > s->needed_bytes += 8; > break; > -- > 2.25.1 > >
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 5f9471d83c..183d3f44c2 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -895,6 +895,9 @@ static void decode_fast_read_cmd(Flash *s) s->needed_bytes = get_addr_length(s); switch (get_man(s)) { /* Dummy cycles - modeled with bytes writes instead of bits */ + case MAN_SST: + s->needed_bytes += 1; + break; case MAN_WINBOND: s->needed_bytes += 8; break;