diff mbox series

[3/3] scripts/ci/gitlab-pipeline-status: give more info when pipeline not found

Message ID 20210222193240.921250-4-crosa@redhat.com
State New
Headers show
Series gitlab-pipeline-status script: provide more information on errors | expand

Commit Message

Cleber Rosa Feb. 22, 2021, 7:32 p.m. UTC 
This includes both input parameters (project id and commit) in the
message so to make it easier to debug returned API calls.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 scripts/ci/gitlab-pipeline-status | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Wainer dos Santos Moschetta Feb. 23, 2021, 2:43 p.m. UTC | #1 
On 2/22/21 4:32 PM, Cleber Rosa wrote:
> This includes both input parameters (project id and commit) in the
> message so to make it easier to debug returned API calls.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   scripts/ci/gitlab-pipeline-status | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
> index ad62ab3cfc..924db327ff 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -74,7 +74,9 @@ def get_pipeline_status(project_id, commit_sha1):
>       # project + commit. If this assumption is false, we can add further
>       # filters to the url, such as username, and order_by.
>       if not json_response:
> -        raise NoPipelineFound("No pipeline found")
> +        msg = "No pipeline found for project %s and commit %s" % (project_id,
> +                                                                  commit_sha1)
> +        raise NoPipelineFound(msg)
>       return json_response[0]
>   
>
diff mbox series

Patch

diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
index ad62ab3cfc..924db327ff 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -74,7 +74,9 @@  def get_pipeline_status(project_id, commit_sha1):
     # project + commit. If this assumption is false, we can add further
     # filters to the url, such as username, and order_by.
     if not json_response:
-        raise NoPipelineFound("No pipeline found")
+        msg = "No pipeline found for project %s and commit %s" % (project_id,
+                                                                  commit_sha1)
+        raise NoPipelineFound(msg)
     return json_response[0]