diff mbox series

[v1,3/7] spapr_rtas.c: fix identation in rtas_ibm_nmi_interlock() string

Message ID 20210114180628.1675603-4-danielhb413@gmail.com
State New
Headers show
Series pseries: avoid unplug the last online CPU core + assorted fixes | expand

Commit Message

Daniel Henrique Barboza Jan. 14, 2021, 6:06 p.m. UTC 
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/spapr_rtas.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Gibson Jan. 15, 2021, 12:44 a.m. UTC | #1 
On Thu, Jan 14, 2021 at 03:06:24PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Nack.  I believe the general consensus is that greppability for long
error message strings is sufficient reason to break the normal coding
style rules.

> ---
>  hw/ppc/spapr_rtas.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 513c7a8435..d014684d60 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -463,7 +463,8 @@ static void rtas_ibm_nmi_interlock(PowerPCCPU *cpu,
>  
>      if (spapr->fwnmi_machine_check_addr == -1) {
>          qemu_log_mask(LOG_GUEST_ERROR,
> -"FWNMI: ibm,nmi-interlock RTAS called with FWNMI not registered.\n");
> +                      "FWNMI: ibm,nmi-interlock RTAS called with "
> +                      "FWNMI not registered.\n");
>  
>          /* NMI register not called */
>          rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
diff mbox series

Patch

diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index 513c7a8435..d014684d60 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -463,7 +463,8 @@  static void rtas_ibm_nmi_interlock(PowerPCCPU *cpu,
 
     if (spapr->fwnmi_machine_check_addr == -1) {
         qemu_log_mask(LOG_GUEST_ERROR,
-"FWNMI: ibm,nmi-interlock RTAS called with FWNMI not registered.\n");
+                      "FWNMI: ibm,nmi-interlock RTAS called with "
+                      "FWNMI not registered.\n");
 
         /* NMI register not called */
         rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);