Message ID | 20201115162613.74645-1-thuth@redhat.com |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20201115162613.74645-1-thuth@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20201115162613.74645-1-thuth@redhat.com Type: series Subject: [PULL 00/26] Fixes for Lesser GPL license statements === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201115162613.74645-1-thuth@redhat.com -> patchew/20201115162613.74645-1-thuth@redhat.com Switched to a new branch 'test' b8a6401 nomaintainer: Fix Lesser GPL version number 0bd27b8 test: Fix LGPL information in the file headers 48561d1 tests/acceptance: Fix LGPL information in the file headers 1d03e31 tests/migration: Fix LGPL information in the file headers bde25a0 sparc tcg cpus: Fix Lesser GPL version number 29f0dee e1000e: Fix Lesser GPL version number e9b5112 x86 hvf cpus: Fix Lesser GPL version number 9eb81d0 nvdimm: Fix Lesser GPL version number 17d589a w32: Fix Lesser GPL version number 2ecb2d9 tpm: Fix Lesser GPL version number ba8b9d2 overall/alpha tcg cpus|hppa: Fix Lesser GPL version number 7d09687 overall usermode...: Fix Lesser GPL version number ea61888 migration: Fix Lesser GPL version number ed0741d parallel nor flash: Fix Lesser GPL version number 300fe9f arm tcg cpus: Fix Lesser GPL version number 0e9f515 x86 tcg cpus: Fix Lesser GPL version number b008727 linux user: Fix Lesser GPL version number 681ac28 usb: Fix Lesser GPL version number 3a215fd tricore tcg cpus: Fix Lesser GPL version number c8afdda xtensa tcg cpus: Fix Lesser GPL version number 5c21ec3 prep: Fix Lesser GPL version number c3ccccc microblaze tcg cpus: Fix Lesser GPL version number 24b71f2 cris tcg cpus: Fix Lesser GPL version number 64a6521 powerpc tcg: Fix Lesser GPL version number 8b23554 non-virt: Fix Lesser GPL version number f0ded63 semihosting: Fix Lesser GPL version number === OUTPUT BEGIN === 1/26 Checking commit f0ded63e3c8f (semihosting: Fix Lesser GPL version number) 2/26 Checking commit 8b23554de92c (non-virt: Fix Lesser GPL version number) 3/26 Checking commit 64a652169605 (powerpc tcg: Fix Lesser GPL version number) 4/26 Checking commit 24b71f209dd9 (cris tcg cpus: Fix Lesser GPL version number) 5/26 Checking commit c3ccccc834b5 (microblaze tcg cpus: Fix Lesser GPL version number) 6/26 Checking commit 5c21ec3fa07d (prep: Fix Lesser GPL version number) 7/26 Checking commit c8afddabef6f (xtensa tcg cpus: Fix Lesser GPL version number) 8/26 Checking commit 3a215fda2a1f (tricore tcg cpus: Fix Lesser GPL version number) 9/26 Checking commit 681ac28f492b (usb: Fix Lesser GPL version number) 10/26 Checking commit b00872742226 (linux user: Fix Lesser GPL version number) 11/26 Checking commit 0e9f51546310 (x86 tcg cpus: Fix Lesser GPL version number) 12/26 Checking commit 300fe9f0e97b (arm tcg cpus: Fix Lesser GPL version number) 13/26 Checking commit ed0741d251dc (parallel nor flash: Fix Lesser GPL version number) 14/26 Checking commit ea618883f1d2 (migration: Fix Lesser GPL version number) 15/26 Checking commit 7d09687eabf6 (overall usermode...: Fix Lesser GPL version number) 16/26 Checking commit ba8b9d2555d6 (overall/alpha tcg cpus|hppa: Fix Lesser GPL version number) 17/26 Checking commit 2ecb2d95621b (tpm: Fix Lesser GPL version number) 18/26 Checking commit 17d589aa5a7c (w32: Fix Lesser GPL version number) 19/26 Checking commit 9eb81d0746d5 (nvdimm: Fix Lesser GPL version number) 20/26 Checking commit e9b5112455d4 (x86 hvf cpus: Fix Lesser GPL version number) ERROR: do not use C99 // comments #153: FILE: target/i386/hvf/x86_emu.c:26: +// version 2.1 of the License, or (at your option) any later version. ERROR: do not use C99 // comments #179: FILE: target/i386/hvf/x86_flags.c:9: +// version 2.1 of the License, or (at your option) any later version. ERROR: do not use C99 // comments #192: FILE: target/i386/hvf/x86_flags.h:9: +// version 2.1 of the License, or (at your option) any later version. total: 3 errors, 0 warnings, 144 lines checked Patch 20/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/26 Checking commit 29f0dee12e65 (e1000e: Fix Lesser GPL version number) ERROR: space prohibited between function name and open parenthesis '(' #27: FILE: hw/net/e1000e.c:25: +* version 2.1 of the License, or (at your option) any later version. ERROR: space prohibited between function name and open parenthesis '(' #40: FILE: hw/net/e1000e_core.c:25: +* version 2.1 of the License, or (at your option) any later version. ERROR: space prohibited between function name and open parenthesis '(' #53: FILE: hw/net/e1000e_core.h:25: +* version 2.1 of the License, or (at your option) any later version. ERROR: space prohibited between function name and open parenthesis '(' #66: FILE: hw/net/e1000x_common.c:14: +* version 2.1 of the License, or (at your option) any later version. ERROR: space prohibited between function name and open parenthesis '(' #79: FILE: hw/net/e1000x_common.h:14: +* version 2.1 of the License, or (at your option) any later version. total: 5 errors, 0 warnings, 40 lines checked Patch 21/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/26 Checking commit bde25a048704 (sparc tcg cpus: Fix Lesser GPL version number) ERROR: space prohibited between function name and open parenthesis '(' #144: FILE: target/sparc/translate.c:10: + version 2.1 of the License, or (at your option) any later version. total: 1 errors, 0 warnings, 96 lines checked Patch 22/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/26 Checking commit 1d03e31cf01f (tests/migration: Fix LGPL information in the file headers) 24/26 Checking commit 48561d10e6ce (tests/acceptance: Fix LGPL information in the file headers) 25/26 Checking commit 0bd27b864cce (test: Fix LGPL information in the file headers) 26/26 Checking commit b8a6401e1126 (nomaintainer: Fix Lesser GPL version number) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201115162613.74645-1-thuth@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Sun, 15 Nov 2020 at 16:26, Thomas Huth <thuth@redhat.com> wrote: > > Hi Peter, > > the following changes since commit b50ea0d54bbca7d440315c3d0c0f7a4d6537b180: > > Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201113-1' into staging (2020-11-14 11:22:07 +0000) > > are available in the Git repository at: > > https://gitlab.com/huth/qemu.git tags/pull-request-2020-11-15 > > for you to fetch changes up to 61f3c91a67c4695dee6904d841b393ea21003969: > > nomaintainer: Fix Lesser GPL version number (2020-11-15 17:04:40 +0100) > > ---------------------------------------------------------------- > Fix Lesser GPL license versions (should be "2.1" and not "2") > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM