| Message ID | 20200827110311.164316-9-kuhn.chenqun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | trivial patchs for static code analyzer fixes | expand |
On Thu, Aug 27, 2020 at 07:03:09PM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read > pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Le 27/08/2020 à 13:03, Chen Qun a écrit : > Clang static code analyzer show warning: > qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read > pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Markus Armbruster <armbru@redhat.com> > --- > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Markus Armbruster <armbru@redhat.com> > > v2->v3: The format of the snprintf statement is modified(Base on Markus review). > --- > hw/usb/bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/usb/bus.c b/hw/usb/bus.c > index b17bda3b29..2b11041451 100644 > --- a/hw/usb/bus.c > +++ b/hw/usb/bus.c > @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) > in++; > } else { > /* the device itself */ > - pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", > - qdev_fw_name(qdev), nr); > + snprintf(fw_path + pos, fw_len - pos, "%s@%lx", > + qdev_fw_name(qdev), nr); > break; > } > } > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29..2b11041451 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) in++; } else { /* the device itself */ - pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", - qdev_fw_name(qdev), nr); + snprintf(fw_path + pos, fw_len - pos, "%s@%lx", + qdev_fw_name(qdev), nr); break; } }
Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> --- Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> v2->v3: The format of the snprintf statement is modified(Base on Markus review). --- hw/usb/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)