| Message ID | 20200708200104.21978-2-alxndr@bu.edu |
|---|---|
| State | New |
| Headers | show |
| Series | fuzz: broken build fixes | expand |
Alexander Bulekov <alxndr@bu.edu> 于2020年7月9日周四 上午4:02写道： > > When configuring with --enable-fuzzing, we overwrote the CFLAGS > added by all the preceding checks. Instead of overwriting CFLAGS, append > the ones we need. > > Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing") > Reported-by: Li Qiang <liq3ea@163.com> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> Tested-by: Li Qiang <liq3ea@gmail.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ee6c3c6792..078ebaa9f3 100755 > --- a/configure > +++ b/configure > @@ -7898,7 +7898,7 @@ if test "$fuzzing" = "yes" ; then > if test "$have_fuzzer" = "yes"; then > FUZZ_LDFLAGS=" -fsanitize=address,fuzzer" > FUZZ_CFLAGS=" -fsanitize=address,fuzzer" > - CFLAGS=" -fsanitize=address,fuzzer-no-link" > + CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link" > else > error_exit "Your compiler doesn't support -fsanitize=address,fuzzer" > exit 1 > -- > 2.26.2 > >
On 7/8/20 10:01 PM, Alexander Bulekov wrote: > When configuring with --enable-fuzzing, we overwrote the CFLAGS > added by all the preceding checks. Instead of overwriting CFLAGS, append > the ones we need. > > Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing") > Reported-by: Li Qiang <liq3ea@163.com> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ee6c3c6792..078ebaa9f3 100755 > --- a/configure > +++ b/configure > @@ -7898,7 +7898,7 @@ if test "$fuzzing" = "yes" ; then > if test "$have_fuzzer" = "yes"; then > FUZZ_LDFLAGS=" -fsanitize=address,fuzzer" > FUZZ_CFLAGS=" -fsanitize=address,fuzzer" > - CFLAGS=" -fsanitize=address,fuzzer-no-link" > + CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link" > else > error_exit "Your compiler doesn't support -fsanitize=address,fuzzer" > exit 1 > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/configure b/configure index ee6c3c6792..078ebaa9f3 100755 --- a/configure +++ b/configure @@ -7898,7 +7898,7 @@ if test "$fuzzing" = "yes" ; then if test "$have_fuzzer" = "yes"; then FUZZ_LDFLAGS=" -fsanitize=address,fuzzer" FUZZ_CFLAGS=" -fsanitize=address,fuzzer" - CFLAGS=" -fsanitize=address,fuzzer-no-link" + CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link" else error_exit "Your compiler doesn't support -fsanitize=address,fuzzer" exit 1
When configuring with --enable-fuzzing, we overwrote the CFLAGS added by all the preceding checks. Instead of overwriting CFLAGS, append the ones we need. Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing") Reported-by: Li Qiang <liq3ea@163.com> Signed-off-by: Alexander Bulekov <alxndr@bu.edu> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)