| Message ID | 20200620232947.17895-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | .travis.yml: Build acceptance tests with -O2 compiler optimization | expand |
On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote: > As we just want the tests to succeed, build them with compiler > optimizations enabled to run the tests faster. Maybe it is a good opportunity to test -O3 instead... Since this configuration is not covered. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 74158f741b..61b247db9f 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -293,7 +293,7 @@ jobs: > - name: "GCC check-acceptance" > dist: bionic > env: > - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" > + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" > - TEST_CMD="make check-acceptance" > - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance" > after_script: >
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote: >> As we just want the tests to succeed, build them with compiler >> optimizations enabled to run the tests faster. > > Maybe it is a good opportunity to test -O3 instead... > Since this configuration is not covered. Don't know if -O3 is worth it - even Gentoo developers warn against cranking it up too much. In fact I'm surprised we don't build -O2 by default. > >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> .travis.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 74158f741b..61b247db9f 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -293,7 +293,7 @@ jobs: >> - name: "GCC check-acceptance" >> dist: bionic >> env: >> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >> - TEST_CMD="make check-acceptance" >> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance" >> after_script: >>
On 6/21/20 2:47 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > >> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote: >>> As we just want the tests to succeed, build them with compiler >>> optimizations enabled to run the tests faster. >> >> Maybe it is a good opportunity to test -O3 instead... >> Since this configuration is not covered. > > Don't know if -O3 is worth it - even Gentoo developers warn against > cranking it up too much. > > In fact I'm surprised we don't build -O2 by default. Do you mean in Travis or directly in ./configure? > >> >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> .travis.yml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index 74158f741b..61b247db9f 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -293,7 +293,7 @@ jobs: >>> - name: "GCC check-acceptance" >>> dist: bionic >>> env: >>> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >>> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >>> - TEST_CMD="make check-acceptance" >>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance" >>> after_script: >>> > >
On 6/21/20 8:05 PM, Philippe Mathieu-Daudé wrote: > On 6/21/20 2:47 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé <f4bug@amsat.org> writes: >> >>> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote: >>>> As we just want the tests to succeed, build them with compiler >>>> optimizations enabled to run the tests faster. >>> >>> Maybe it is a good opportunity to test -O3 instead... >>> Since this configuration is not covered. >> >> Don't know if -O3 is worth it - even Gentoo developers warn against >> cranking it up too much. >> >> In fact I'm surprised we don't build -O2 by default. > > Do you mean in Travis or directly in ./configure? Indeed ./configure uses -O2 is by default since 2005 :) (commits c326e0afec0 / 6f30fa853b7 / ce278618b08). > >> >>> >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> .travis.yml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/.travis.yml b/.travis.yml >>>> index 74158f741b..61b247db9f 100644 >>>> --- a/.travis.yml >>>> +++ b/.travis.yml >>>> @@ -293,7 +293,7 @@ jobs: >>>> - name: "GCC check-acceptance" >>>> dist: bionic >>>> env: >>>> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >>>> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" >>>> - TEST_CMD="make check-acceptance" >>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance" >>>> after_script: >>>> >> >> >
diff --git a/.travis.yml b/.travis.yml index 74158f741b..61b247db9f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -293,7 +293,7 @@ jobs: - name: "GCC check-acceptance" dist: bionic env: - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu" - TEST_CMD="make check-acceptance" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance" after_script:
As we just want the tests to succeed, build them with compiler optimizations enabled to run the tests faster. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)