From patchwork Tue Mar 24 08:22:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Qun X-Patchwork-Id: 1260517 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48mkqx1mMhz9sQt for ; Tue, 24 Mar 2020 19:26:52 +1100 (AEDT) Received: from localhost ([::1]:44338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGetd-0000d7-Bf for incoming@patchwork.ozlabs.org; Tue, 24 Mar 2020 04:26:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36009) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGeq8-0005DL-Ri for qemu-devel@nongnu.org; Tue, 24 Mar 2020 04:23:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGeq7-0004Wr-MR for qemu-devel@nongnu.org; Tue, 24 Mar 2020 04:23:12 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3210 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGeq7-0004S5-9N; Tue, 24 Mar 2020 04:23:11 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B57C214C98A19D3E52B3; Tue, 24 Mar 2020 16:23:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 24 Mar 2020 16:22:56 +0800 From: Chen Qun To: , Subject: [PATCH v4 1/3] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() Date: Tue, 24 Mar 2020 16:22:33 +0800 Message-ID: <20200324082235.27980-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200324082235.27980-1-kuhn.chenqun@huawei.com> References: <20200324082235.27980-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, laurent@vivier.eu, Paolo Bonzini , Euler Robot , Chen Qun , philmd@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Paolo Bonzini Cc:Fam Zheng v1->v2: keep ' size = 4' and add 'g_assert(size >= 4)' after if() statement. (Base on Laurent's comments) --- hw/scsi/esp-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..497a8d5901 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, addr &= ~3; size = 4; } + g_assert(size >= 4); if (addr < 0x40) { /* SCSI core reg */