| Message ID | 20191204190836.31324-2-vgoyal@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | virtiofsd, vhost-user-fs: Add support for notification queue | expand |
* Vivek Goyal (vgoyal@redhat.com) wrote: > There are some unused fields in "struct fv_QueueInfo". Get rid of these fields. > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> > --- > contrib/virtiofsd/fuse_virtio.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > index 31c8542b6c..2a9cd60a01 100644 > --- a/contrib/virtiofsd/fuse_virtio.c > +++ b/contrib/virtiofsd/fuse_virtio.c > @@ -50,12 +50,6 @@ struct fv_QueueInfo { > int qidx; > int kick_fd; > int kill_fd; /* For killing the thread */ > - > - /* The element for the command currently being processed */ > - VuVirtqElement *qe; > - /* If any of the qe vec elements (towards vmm) are unmappable */ > - unsigned int elem_bad_in; > - bool reply_sent; Yep, those last two got moved into FVRequest as part of the thread pool stuff. Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > }; > > /* A FUSE request */ > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > * Vivek Goyal (vgoyal@redhat.com) wrote: > > There are some unused fields in "struct fv_QueueInfo". Get rid of these fields. > > > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> > > --- > > contrib/virtiofsd/fuse_virtio.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > > index 31c8542b6c..2a9cd60a01 100644 > > --- a/contrib/virtiofsd/fuse_virtio.c > > +++ b/contrib/virtiofsd/fuse_virtio.c > > @@ -50,12 +50,6 @@ struct fv_QueueInfo { > > int qidx; > > int kick_fd; > > int kill_fd; /* For killing the thread */ > > - > > - /* The element for the command currently being processed */ > > - VuVirtqElement *qe; > > - /* If any of the qe vec elements (towards vmm) are unmappable */ > > - unsigned int elem_bad_in; > > - bool reply_sent; > > Yep, those last two got moved into FVRequest as part of the thread pool > stuff. > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> I've merged that 1/5 into my world. > > }; > > > > /* A FUSE request */ > > -- > > 2.20.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > _______________________________________________ > Virtio-fs mailing list > Virtio-fs@redhat.com > https://www.redhat.com/mailman/listinfo/virtio-fs -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c index 31c8542b6c..2a9cd60a01 100644 --- a/contrib/virtiofsd/fuse_virtio.c +++ b/contrib/virtiofsd/fuse_virtio.c @@ -50,12 +50,6 @@ struct fv_QueueInfo { int qidx; int kick_fd; int kill_fd; /* For killing the thread */ - - /* The element for the command currently being processed */ - VuVirtqElement *qe; - /* If any of the qe vec elements (towards vmm) are unmappable */ - unsigned int elem_bad_in; - bool reply_sent; }; /* A FUSE request */
There are some unused fields in "struct fv_QueueInfo". Get rid of these fields. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- contrib/virtiofsd/fuse_virtio.c | 6 ------ 1 file changed, 6 deletions(-)