From patchwork Fri Mar 22 09:28:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 1061016 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44QdkC6W5mz9sN1 for ; Fri, 22 Mar 2019 20:33:07 +1100 (AEDT) Received: from localhost ([127.0.0.1]:54508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7GXx-0000r8-PQ for incoming@patchwork.ozlabs.org; Fri, 22 Mar 2019 05:33:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7GTo-0006WC-Fw for qemu-devel@nongnu.org; Fri, 22 Mar 2019 05:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7GTm-0004WC-L1 for qemu-devel@nongnu.org; Fri, 22 Mar 2019 05:28:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42356) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7GTk-0004P3-8d for qemu-devel@nongnu.org; Fri, 22 Mar 2019 05:28:44 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F64BC1306FF; Fri, 22 Mar 2019 09:28:42 +0000 (UTC) Received: from jason-ThinkPad-X1-Carbon-6th.redhat.com (ovpn-12-96.pek2.redhat.com [10.72.12.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEA2F5D9D2; Fri, 22 Mar 2019 09:28:31 +0000 (UTC) From: Jason Wang To: mst@redhat.com, yan@daynix.com, yuri.benditovich@daynix.com, qemu-devel@nongnu.org Date: Fri, 22 Mar 2019 17:28:04 +0800 Message-Id: <20190322092806.21838-3-jasowang@redhat.com> In-Reply-To: <20190322092806.21838-1-jasowang@redhat.com> References: <20190322092806.21838-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 22 Mar 2019 09:28:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFT 2/4] virtio-pci: set enabled for legacy device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" We don't set enabled for legacy device, this turns out to be an issue if we want to check it through vhost. So just simply set it when setting pa of a virtqueue. Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index cb44e19b67..887ee2783c 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -306,8 +306,10 @@ static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) if (pa == 0) { virtio_pci_reset(DEVICE(proxy)); } - else + else { virtio_queue_set_addr(vdev, vdev->queue_sel, pa); + proxy->vqs[vdev->queue_sel].enabled = 1; + } break; case VIRTIO_PCI_QUEUE_SEL: if (val < VIRTIO_QUEUE_MAX)