mbox

[PULL,00/33] final s390x patches for 4.0 soft freeze

Message ID 20190311090322.21603-1-cohuck@redhat.com
State New
Headers show

Pull-request

https://github.com/cohuck/qemu tags/s390x-20190311

Message

Cornelia Huck March 11, 2019, 9:02 a.m. UTC 
The following changes since commit e2a18635a400b0e68679614132e9ef6316105590:

  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +0000)

are available in the Git repository at:

  https://github.com/cohuck/qemu tags/s390x-20190311

for you to fetch changes up to 2c7590c8ea90a7fbe1efcac90cdfdb8017c1b365:

  s390x/tcg: Implement VECTOR UNPACK * (2019-03-11 09:31:01 +0100)

----------------------------------------------------------------
s390x update:
- clean up LowCore definition
- first part of vector instruction support for tcg

----------------------------------------------------------------

David Hildenbrand (32):
  s390x/tcg: Define vector instruction formats
  s390x/tcg: Check vector register instructions at central point
  s390x/tcg: Utilities for vector instruction helpers
  s390x/tcg: Implement VECTOR GATHER ELEMENT
  s390x/tcg: Implement VECTOR GENERATE BYTE MASK
  s390x/tcg: Implement VECTOR GENERATE MASK
  s390x/tcg: Implement VECTOR LOAD
  s390x/tcg: Implement VECTOR LOAD AND REPLICATE
  s390x/tcg: Implement VECTOR LOAD ELEMENT
  s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
  s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
  s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
  s390x/tcg: Implement VECTOR LOAD MULTIPLE
  s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
  s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
  s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
  s390x/tcg: Implement VECTOR LOAD WITH LENGTH
  s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
  s390x/tcg: Implement VECTOR PACK *
  s390x/tcg: Implement VECTOR PERMUTE
  s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
  s390x/tcg: Implement VECTOR REPLICATE
  s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
  s390x/tcg: Implement VECTOR SCATTER ELEMENT
  s390x/tcg: Implement VECTOR SELECT
  s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
  s390x/tcg: Provide probe_write_access helper
  s390x/tcg: Implement VECTOR STORE
  s390x/tcg: Implement VECTOR STORE ELEMENT
  s390x/tcg: Implement VECTOR STORE MULTIPLE
  s390x/tcg: Implement VECTOR STORE WITH LENGTH
  s390x/tcg: Implement VECTOR UNPACK *

Thomas Huth (1):
  target/s390x: Remove non-architected entries from struct LowCore

 target/s390x/Makefile.objs      |   1 +
 target/s390x/cpu.h              |   7 +
 target/s390x/helper.h           |  21 +
 target/s390x/insn-data.def      |  82 +++
 target/s390x/insn-format.def    |  25 +
 target/s390x/internal.h         |  43 +-
 target/s390x/mem_helper.c       |  26 +
 target/s390x/translate.c        |  61 ++-
 target/s390x/translate_vx.inc.c | 935 ++++++++++++++++++++++++++++++++
 target/s390x/vec.h              | 101 ++++
 target/s390x/vec_helper.c       | 193 +++++++
 11 files changed, 1455 insertions(+), 40 deletions(-)
 create mode 100644 target/s390x/translate_vx.inc.c
 create mode 100644 target/s390x/vec.h
 create mode 100644 target/s390x/vec_helper.c

Comments

no-reply@patchew.org March 11, 2019, 9:37 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190311090322.21603-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190311090322.21603-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/33] final s390x patches for 4.0 soft freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190311090322.21603-1-cohuck@redhat.com -> patchew/20190311090322.21603-1-cohuck@redhat.com
Switched to a new branch 'test'
6fc0caa276 s390x/tcg: Implement VECTOR UNPACK *
8c665bc916 s390x/tcg: Implement VECTOR STORE WITH LENGTH
352d38b80b s390x/tcg: Implement VECTOR STORE MULTIPLE
11d2367e20 s390x/tcg: Implement VECTOR STORE ELEMENT
c192644492 s390x/tcg: Implement VECTOR STORE
4c54d965cf s390x/tcg: Provide probe_write_access helper
e326642baa s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
c989fb8ba3 s390x/tcg: Implement VECTOR SELECT
8de154d3b0 s390x/tcg: Implement VECTOR SCATTER ELEMENT
fe7a9572a2 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
40f8f304e4 s390x/tcg: Implement VECTOR REPLICATE
8a1a136e0c s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
fa47afc636 s390x/tcg: Implement VECTOR PERMUTE
32716bd778 s390x/tcg: Implement VECTOR PACK *
acbe85c65a s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
be5bae9cf6 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
db9a9a1c87 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
de07807766 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
14d007a31f s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
2f38fdf0ea s390x/tcg: Implement VECTOR LOAD MULTIPLE
f3bfde147d s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
94eafef4c1 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
ea7abbfabc s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
244f1ac63e s390x/tcg: Implement VECTOR LOAD ELEMENT
94e83610b2 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
ef268990e2 s390x/tcg: Implement VECTOR LOAD
abbba0c2f7 s390x/tcg: Implement VECTOR GENERATE MASK
981729a07c s390x/tcg: Implement VECTOR GENERATE BYTE MASK
96e2d9324c s390x/tcg: Implement VECTOR GATHER ELEMENT
f0d6fbae94 s390x/tcg: Utilities for vector instruction helpers
8e1f046956 s390x/tcg: Check vector register instructions at central point
bfa6562026 s390x/tcg: Define vector instruction formats
0556ef89fa target/s390x: Remove non-architected entries from struct LowCore

=== OUTPUT BEGIN ===
1/33 Checking commit 0556ef89fa8c (target/s390x: Remove non-architected entries from struct LowCore)
2/33 Checking commit bfa65620262d (s390x/tcg: Define vector instruction formats)
3/33 Checking commit 8e1f0469565b (s390x/tcg: Check vector register instructions at central point)
4/33 Checking commit f0d6fbae9446 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 4/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/33 Checking commit 96e2d9324cf9 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 5/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/33 Checking commit 981729a07c2d (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
7/33 Checking commit abbba0c2f743 (s390x/tcg: Implement VECTOR GENERATE MASK)
8/33 Checking commit ef268990e2bb (s390x/tcg: Implement VECTOR LOAD)
9/33 Checking commit 94e83610b27d (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
10/33 Checking commit 244f1ac63e5e (s390x/tcg: Implement VECTOR LOAD ELEMENT)
11/33 Checking commit ea7abbfabca6 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
12/33 Checking commit 94eafef4c1c2 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
13/33 Checking commit f3bfde147dd9 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
14/33 Checking commit 2f38fdf0ead9 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
15/33 Checking commit 14d007a31fdc (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#99: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 15/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/33 Checking commit de07807766c8 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
17/33 Checking commit db9a9a1c87a3 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
18/33 Checking commit be5bae9cf6d7 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
19/33 Checking commit acbe85c65a86 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
20/33 Checking commit 32716bd778b2 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#185: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 20/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

21/33 Checking commit fa47afc636e2 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#23: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 21/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/33 Checking commit 8a1a136e0c8e (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
23/33 Checking commit 40f8f304e485 (s390x/tcg: Implement VECTOR REPLICATE)
24/33 Checking commit fe7a9572a292 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
25/33 Checking commit 8de154d3b045 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
26/33 Checking commit c989fb8ba38c (s390x/tcg: Implement VECTOR SELECT)
27/33 Checking commit e326642baa0f (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
28/33 Checking commit 4c54d965cff9 (s390x/tcg: Provide probe_write_access helper)
29/33 Checking commit c19264449293 (s390x/tcg: Implement VECTOR STORE)
30/33 Checking commit 11d2367e201d (s390x/tcg: Implement VECTOR STORE ELEMENT)
31/33 Checking commit 352d38b80b95 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
32/33 Checking commit 8c665bc91663 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
33/33 Checking commit 6fc0caa27678 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190311090322.21603-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell March 11, 2019, 5:16 p.m. UTC | #2 
On Mon, 11 Mar 2019 at 09:03, Cornelia Huck <cohuck@redhat.com> wrote:
>
> The following changes since commit e2a18635a400b0e68679614132e9ef6316105590:
>
>   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/cohuck/qemu tags/s390x-20190311
>
> for you to fetch changes up to 2c7590c8ea90a7fbe1efcac90cdfdb8017c1b365:
>
>   s390x/tcg: Implement VECTOR UNPACK * (2019-03-11 09:31:01 +0100)
>
> ----------------------------------------------------------------
> s390x update:
> - clean up LowCore definition
> - first part of vector instruction support for tcg
>
> ----------------------------------------------------------------
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM