diff mbox series

[for-3.1,07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

Message ID 20181125205000.10324-8-philmd@redhat.com
State New
Headers show
Series MAINTAINERS: Add various missing entries | expand

Commit Message

Philippe Mathieu-Daudé Nov. 25, 2018, 8:49 p.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Markovic Nov. 26, 2018, 1:34 p.m. UTC | #1 
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)


Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com>


> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>   S: Odd Fixes
>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c
> +F: hw/pci-host/bonito.c
>   
>   F: include/hw/isa/vt82c686.h
>
Thomas Huth Nov. 27, 2018, 9:49 a.m. UTC | #2 
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> +F: hw/pci-host/bonito.c
>  
>  F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we
could use my patch here from last Thursday instead:

 https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

 Thomas
Aleksandar Markovic Nov. 27, 2018, 9:58 a.m. UTC | #3 
I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar
Philippe Mathieu-Daudé Nov. 27, 2018, 10:25 a.m. UTC | #4 
On 27/11/18 10:58, Aleksandar Markovic wrote:

[moving Aleksandar reply down to avoid top-posting on technical list]

> From: Thomas Huth <thuth@redhat.com>
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index aa17e9bbd3..81a22b2ccf 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>>  S: Odd Fixes
>>  F: hw/mips/mips_fulong2e.c
>>  F: hw/isa/vt82c686.c
>> +F: hw/pci-host/bonito.c
>>
>>  F: include/hw/isa/vt82c686.h
> 
> Please remove the empty line between bonito.c and vt82c686.h - or we
> could use my patch here from last Thursday instead:
> 
>  https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

> I like better the patch that Thomas linked to. I think Philippe should
have included Thomas' patch, rather than creating new, overlapping,
patches. Confusion about straitforward things! Aleksandar

Yes you are right, I missed Thomas's patch, so please disregard mine.

Thanks!

Phil.

> 
>  Thomas
> 
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index aa17e9bbd3..81a22b2ccf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -864,6 +864,7 @@  R: Stefan Markovic <smarkovic@wavecomp.com>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
 F: include/hw/isa/vt82c686.h