diff mbox series

[v1,8/8] s390x/tcg: refactor specification checking

Message ID 20180822075750.12399-9-david@redhat.com
State New
Headers show
Series s390x/tcg: instruction flags and AFP registers | expand

Commit Message

David Hildenbrand Aug. 22, 2018, 7:57 a.m. UTC 
We can fit this nicely into less LOC, without harming readability.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/translate.c | 34 ++++++----------------------------
 1 file changed, 6 insertions(+), 28 deletions(-)
diff mbox series

Patch

diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 27d2405ef4..3675da1270 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -6053,34 +6053,12 @@  static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
 
     /* Check for insn specification exceptions.  */
     if (insn->spec) {
-        int spec = insn->spec, excp = 0, r;
-
-        if (spec & SPEC_r1_even) {
-            r = get_field(&f, r1);
-            if (r & 1) {
-                excp = PGM_SPECIFICATION;
-            }
-        }
-        if (spec & SPEC_r2_even) {
-            r = get_field(&f, r2);
-            if (r & 1) {
-                excp = PGM_SPECIFICATION;
-            }
-        }
-        if (spec & SPEC_r3_even) {
-            r = get_field(&f, r3);
-            if (r & 1) {
-                excp = PGM_SPECIFICATION;
-            }
-        }
-        if ((spec & SPEC_r1_f128) && !is_fp_pair(get_field(&f, r1))) {
-            excp = PGM_SPECIFICATION;
-        }
-        if ((spec & SPEC_r2_f128) && !is_fp_pair(get_field(&f, r2))) {
-            excp = PGM_SPECIFICATION;
-        }
-        if (excp) {
-            gen_program_exception(s, excp);
+        if (((insn->spec & SPEC_r1_even) && (get_field(&f, r1) & 1)) ||
+            ((insn->spec & SPEC_r2_even) && (get_field(&f, r2) & 1)) ||
+            ((insn->spec & SPEC_r3_even) && (get_field(&f, r3) & 1)) ||
+            ((insn->spec & SPEC_r1_f128) && !is_fp_pair(get_field(&f, r1))) ||
+            ((insn->spec & SPEC_r2_f128) && !is_fp_pair(get_field(&f, r2)))) {
+            gen_program_exception(s, PGM_SPECIFICATION);
             return DISAS_NORETURN;
         }
     }