| Message ID | 20180630165448.30795-1-mjt@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
| Series | ui: do not build-depend or link with libdrm, it is not needed | expand |
On 06/30/2018 01:54 PM, Michael Tokarev wrote: > Opengl support brings up libdrm. But actually nothing uses this library > or includes any of its headers. Just remove checking for it from configure. libgbm is linked to libdrm, but I don't see call from QEMU to libdrm, son we don't need to check for it (and his headers) indeed. > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 65548df1fc..951ff022dd 100755 > --- a/configure > +++ b/configure > @@ -3865,7 +3865,7 @@ libs_softmmu="$libs_softmmu $fdt_libs" > # opengl probe (for sdl2, gtk, milkymist-tmu2) > > if test "$opengl" != "no" ; then > - opengl_pkgs="epoxy libdrm gbm" > + opengl_pkgs="epoxy gbm" > if $pkg_config $opengl_pkgs; then > opengl_cflags="$($pkg_config --cflags $opengl_pkgs)" > opengl_libs="$($pkg_config --libs $opengl_pkgs)" >
On Sat, Jun 30, 2018 at 07:54:48PM +0300, Michael Tokarev wrote: > Opengl support brings up libdrm. But actually nothing uses this library > or includes any of its headers. Just remove checking for it from configure. Added to ui queue. thanks, Gerd
diff --git a/configure b/configure index 65548df1fc..951ff022dd 100755 --- a/configure +++ b/configure @@ -3865,7 +3865,7 @@ libs_softmmu="$libs_softmmu $fdt_libs" # opengl probe (for sdl2, gtk, milkymist-tmu2) if test "$opengl" != "no" ; then - opengl_pkgs="epoxy libdrm gbm" + opengl_pkgs="epoxy gbm" if $pkg_config $opengl_pkgs; then opengl_cflags="$($pkg_config --cflags $opengl_pkgs)" opengl_libs="$($pkg_config --libs $opengl_pkgs)"
Opengl support brings up libdrm. But actually nothing uses this library or includes any of its headers. Just remove checking for it from configure. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)