From patchwork Sun Jun 24 04:05:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 933841 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="siNHgui5"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41CzYS0QwGz9s19 for ; Sun, 24 Jun 2018 14:17:48 +1000 (AEST) Received: from localhost ([::1]:40560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwTB-0004DK-Nr for incoming@patchwork.ozlabs.org; Sun, 24 Jun 2018 00:17:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIV-0003u7-9x for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIU-0003rH-9N for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:43 -0400 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:33964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIU-0003r6-5S; Sun, 24 Jun 2018 00:06:42 -0400 Received: by mail-qk0-x22a.google.com with SMTP id b66-v6so348540qkj.1; Sat, 23 Jun 2018 21:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hK9QEGg5qg6ckCjOXMcitnFzKOYf48jdhPmYlKTayek=; b=siNHgui5LVnwZh9ZfjiZyOGzJLyoVhHIr7vRxeVzBM8N742Ng6lqDepB5iml6pDI1k +7NN/yDWOFU927YGy4u923Vv56MgVJnLxAaOxrip8Rck6V9z1uevf4WdGqULFgqIFAbe lykaVitHxaPC40cS/O7wZkwTkjmoF+N3RSvxUMIcoI1Q9O7hRGyL8igBfiJpeSCZOGUz c8iszncxMHscwMCWFtDpM6qkn/T23cxGX2d4phV6RrjarFX6fdhyGOYwIPnqkH/Kp06D l0jFbEvU19HI8yv7hhHyA0S7IyFjdB6TylOXq7B/PkCyAtzmivYV0S2CGXgqWzXLzMd4 5Cuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hK9QEGg5qg6ckCjOXMcitnFzKOYf48jdhPmYlKTayek=; b=jbtH6lYGPrhUAm9hlInqUyY+mDiPjARAKGAeftw6WMv4TUr4MMIZYRJMN2VKqF68Bu 2CRyMIk0Z2wMJhR2sk7jm3u0sXpZRusd5XZzlH8JhJpb70ruOZPh9kA+xv73yNzPPchA WHdAGrenK02Pf3kaXDQsWj8oINtkg6/lsY4Mi8v+acCd6hM5Y8ziAOMsbswT1VX9Vw0I mBinajcJwFSm71p+AGntZNGDwu+7uyU54ftlrgGuujRrLY7OjiFxmgAiI81T0JSoDiae /hLQfwGI3n3QCp+XIpMfpnhOKDqifKvFeIZRi+Beebz0yUvQH812tdWx0Y4hyQlT2fCb IUBg== X-Gm-Message-State: APt69E0qmUUR2L4WoWpQFkWIDs9BbptWGhx7bn+Yfmn7EmwUG1o4AkLm ec72uEaSnx/X4OHRtUcJa3k= X-Google-Smtp-Source: AAOMgpdVmXRmnV3YyXU43Gbtm7TzpYU2BBiUPimbhR9sYj8ID20dIP9rJzWYJ8UsR184wtJGoJMVrA== X-Received: by 2002:a37:a3d2:: with SMTP id m201-v6mr6460403qke.121.1529813201676; Sat, 23 Jun 2018 21:06:41 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:41 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:59 -0300 Message-Id: <20180624040609.17572-7-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22a Subject: [Qemu-devel] [PATCH v3 06/16] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/sd/omap_mmc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c index 5b47cadf11..aa2a816f76 100644 --- a/hw/sd/omap_mmc.c +++ b/hw/sd/omap_mmc.c @@ -17,6 +17,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" #include "hw/sd/sd.h" @@ -449,10 +450,14 @@ static void omap_mmc_write(void *opaque, hwaddr offset, s->enable = (value >> 11) & 1; s->be = (value >> 10) & 1; s->clkdiv = (value >> 0) & (s->rev >= 2 ? 0x3ff : 0xff); - if (s->mode != 0) - printf("SD mode %i unimplemented!\n", s->mode); - if (s->be != 0) - printf("SD FIFO byte sex unimplemented!\n"); + if (s->mode != 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: mode #%i unimplemented\n", s->mode); + } + if (s->be != 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: Big Endian not implemented\n"); + } if (s->dw != 0 && s->lines < 4) printf("4-bit SD bus enabled\n"); if (!s->enable)