From patchwork Sun Jun 24 04:05:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 933839 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pOnkILMu"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41CzVL5v93z9s19 for ; Sun, 24 Jun 2018 14:15:06 +1000 (AEST) Received: from localhost ([::1]:40542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwQa-0001jN-GR for incoming@patchwork.ozlabs.org; Sun, 24 Jun 2018 00:15:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIT-0003sl-BR for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIR-0003qB-MB for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:41 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:41520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIR-0003q5-Hy; Sun, 24 Jun 2018 00:06:39 -0400 Received: by mail-qk0-x22c.google.com with SMTP id d22-v6so169262qkc.8; Sat, 23 Jun 2018 21:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LBtULdpVGZHXXdJeP9a2uG196NqZT+OU//3yrTeMnA8=; b=pOnkILMuWfO0HuAyo+XYeTUaMt2K6Qc75xN/WW+oUY3iEEab+Qbl4z3liVa6wc2WyQ 8W7u/KsVqC/3tzOYDrUX1xaQISEBw9APaIKOqy64krxFsnCoV73XVWiDt+t5fyiGO9xW Jn45vvFox796GF39nwuHJL2mBdlr0Qq8v38lcChXPqJX+Ww7mDxHPtRzwRuWXLzTo870 p9yOrt2iTQ7oKg2dEiypyAmlaXaB0fxYD++Ynj91+z3NxCu+b6Dc5ZLIypIasBEOGXUA QXIgOyvyFhO00lmQJCfDsw2xw21plWKTC5JIvR2Mm+bEw1lSFEaoQ3WjfvIB+p+KsPWG FOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LBtULdpVGZHXXdJeP9a2uG196NqZT+OU//3yrTeMnA8=; b=cniuiamDKz+kMhVt+VG+jJZYy/6NI7xdm+uS6LZ2KzeGX+fAwYSe+zRNbIzP83mtxL TkCx84uVtfy74cZbQFtnVdGIZ2ju3LhofcmCkjgwqdTTkIwqaptHjfT/4WZsrDF1vHXI KmnqqgUHxL1WniTmU+C/9EQpT2GKu0lO09De3E0t4ZjZGqGbsGlaRSHhEHCqwwRCAv5M aDFr9s7mvx5o1GEs2ZFI5Tp3nXrx3eOj3+IrjjKRDeKzdpygj15gsdSmqmrICkyJn91K amVzaUVLhfooSHti7pkJlRR4VYlEeigm8UKSn65Xr702QlJfTqjnBQqERSNaw82XR8l/ bSDw== X-Gm-Message-State: APt69E1reYbEi/WHSUd+JPSdnmP+X75jmXsBnVWibGsGhYT+1N1saCZi 0af7TOmH5jKnJzGd1xUM3GY= X-Google-Smtp-Source: ADUXVKLhdu57UsJFQFnqcKeJbqyJbjBvWh7A/d/n/VcXfrn3ALNICpkXNIKMfbA+jKoy/kFNjQQzAQ== X-Received: by 2002:a37:be06:: with SMTP id o6-v6mr6531255qkf.162.1529813199058; Sat, 23 Jun 2018 21:06:39 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:38 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:58 -0300 Message-Id: <20180624040609.17572-6-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22c Subject: [Qemu-devel] [PATCH v3 05/16] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , qemu-trivial@nongnu.org, Alistair Francis , =?utf-8?q?Philippe_Mathieu?= =?utf-8?q?-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/ssi/omap_spi.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ssi/omap_spi.c b/hw/ssi/omap_spi.c index 34163e5646..f278a55160 100644 --- a/hw/ssi/omap_spi.c +++ b/hw/ssi/omap_spi.c @@ -20,6 +20,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" @@ -294,11 +295,15 @@ static void omap_mcspi_write(void *opaque, hwaddr addr, case 0x2c: /* MCSPI_CHCONF */ if ((value ^ s->ch[ch].config) & (3 << 14)) /* DMAR | DMAW */ omap_mcspi_dmarequest_update(s->ch + ch); - if (((value >> 12) & 3) == 3) /* TRM */ - fprintf(stderr, "%s: invalid TRM value (3)\n", __func__); - if (((value >> 7) & 0x1f) < 3) /* WL */ - fprintf(stderr, "%s: invalid WL value (%" PRIx64 ")\n", - __func__, (value >> 7) & 0x1f); + if (((value >> 12) & 3) == 3) { /* TRM */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid TRM value (3)\n", + __func__); + } + if (((value >> 7) & 0x1f) < 3) { /* WL */ + qemu_log_mask(LOG_GUEST_ERROR, + "%s: invalid WL value (%" PRIx64 ")\n", + __func__, (value >> 7) & 0x1f); + } s->ch[ch].config = value & 0x7fffff; break;