| Message ID | 20180130035827.2360-1-programmingkidx@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Only print unknown command message in debug mode | expand |
Hi John, On 01/30/2018 12:58 AM, John Arbuckle wrote: > After using QEMU with the sb16 sound card I would see all these messages about some numbered command not being understood. It became annoying after a while to always see this message, so this patch changes things so that the message is only printed when DEBUG is defined. > > Signed-off-by: John Arbuckle <programmingkidx@gmail.com> > --- > hw/audio/sb16.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c > index 6ab2f6f89a..45b679c4df 100644 > --- a/hw/audio/sb16.c > +++ b/hw/audio/sb16.c > @@ -632,7 +632,7 @@ static void command (SB16State *s, uint8_t cmd) > return; > > warn: > - dolog ("warning: command %#x,%d is not truly understood yet\n", > + ldebug("warning: command %#x,%d is not truly understood yet\n", > cmd, s->needed_bytes); While changing this file can you use the latest logging API? such: qemu_log_mask(LOG_UNIMP, "unimplemented command 0x%02x (size:%d)", cmd, s->needed_bytes); So one can enable this log level at runtime (with "-d unimp"), the #define DEBUG is compile time (require a rebuild). > goto exit; > >
> On Jan 29, 2018, at 11:17 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Hi John, > > On 01/30/2018 12:58 AM, John Arbuckle wrote: >> After using QEMU with the sb16 sound card I would see all these messages about some numbered command not being understood. It became annoying after a while to always see this message, so this patch changes things so that the message is only printed when DEBUG is defined. >> >> Signed-off-by: John Arbuckle <programmingkidx@gmail.com> >> --- >> hw/audio/sb16.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c >> index 6ab2f6f89a..45b679c4df 100644 >> --- a/hw/audio/sb16.c >> +++ b/hw/audio/sb16.c >> @@ -632,7 +632,7 @@ static void command (SB16State *s, uint8_t cmd) >> return; >> >> warn: >> - dolog ("warning: command %#x,%d is not truly understood yet\n", >> + ldebug("warning: command %#x,%d is not truly understood yet\n", >> cmd, s->needed_bytes); > > While changing this file can you use the latest logging API? such: > > qemu_log_mask(LOG_UNIMP, "unimplemented command 0x%02x (size:%d)", > cmd, s->needed_bytes); > > So one can enable this log level at runtime (with "-d unimp"), the > #define DEBUG is compile time (require a rebuild). > >> goto exit; Absolutely. This is a good idea.
diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index 6ab2f6f89a..45b679c4df 100644 --- a/hw/audio/sb16.c +++ b/hw/audio/sb16.c @@ -632,7 +632,7 @@ static void command (SB16State *s, uint8_t cmd) return; warn: - dolog ("warning: command %#x,%d is not truly understood yet\n", + ldebug("warning: command %#x,%d is not truly understood yet\n", cmd, s->needed_bytes); goto exit;
After using QEMU with the sb16 sound card I would see all these messages about some numbered command not being understood. It became annoying after a while to always see this message, so this patch changes things so that the message is only printed when DEBUG is defined. Signed-off-by: John Arbuckle <programmingkidx@gmail.com> --- hw/audio/sb16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)