| Message ID | 20171130140536.31164-1-cohuck@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | target/s390x: nuke DPRINTF in helper.c | expand |
On 11/30/2017 08:05 AM, Cornelia Huck wrote: > It is not used anywhere. > > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/helper.c | 18 ------------------ > 1 file changed, 18 deletions(-) Yay! One less spot for bit-rotten debug. Reviewed-by: Eric Blake <eblake@redhat.com>
On 30.11.2017 15:05, Cornelia Huck wrote: > It is not used anywhere. > > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/helper.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index 246ba20f0d..35d9741918 100644 > --- a/target/s390x/helper.c > +++ b/target/s390x/helper.c > @@ -31,24 +31,6 @@ > #include "sysemu/sysemu.h" > #endif > > -//#define DEBUG_S390 > -//#define DEBUG_S390_STDOUT > - > -#ifdef DEBUG_S390 > -#ifdef DEBUG_S390_STDOUT > -#define DPRINTF(fmt, ...) \ > - do { fprintf(stderr, fmt, ## __VA_ARGS__); \ > - if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0) > -#else > -#define DPRINTF(fmt, ...) \ > - do { qemu_log(fmt, ## __VA_ARGS__); } while (0) > -#endif > -#else > -#define DPRINTF(fmt, ...) \ > - do { } while (0) > -#endif > - > - > #ifndef CONFIG_USER_ONLY > void s390x_tod_timer(void *opaque) > { > Reviewed-by: David Hildenbrand <david@redhat.com>
On 30.11.2017 15:29, David Hildenbrand wrote: > On 30.11.2017 15:05, Cornelia Huck wrote: >> It is not used anywhere. Right, looks like I move the last user of this macro away during the --disable-tcg rework. Reviewed-by: Thomas Huth <thuth@redhat.com>
On Thu, 30 Nov 2017 15:05:36 +0100 Cornelia Huck <cohuck@redhat.com> wrote: > It is not used anywhere. > > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/helper.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index 246ba20f0d..35d9741918 100644 > --- a/target/s390x/helper.c > +++ b/target/s390x/helper.c > @@ -31,24 +31,6 @@ > #include "sysemu/sysemu.h" > #endif > > -//#define DEBUG_S390 > -//#define DEBUG_S390_STDOUT > - > -#ifdef DEBUG_S390 > -#ifdef DEBUG_S390_STDOUT > -#define DPRINTF(fmt, ...) \ > - do { fprintf(stderr, fmt, ## __VA_ARGS__); \ > - if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0) > -#else > -#define DPRINTF(fmt, ...) \ > - do { qemu_log(fmt, ## __VA_ARGS__); } while (0) > -#endif > -#else > -#define DPRINTF(fmt, ...) \ > - do { } while (0) > -#endif > - > - > #ifndef CONFIG_USER_ONLY > void s390x_tod_timer(void *opaque) > { Queued to s390-next.
diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 246ba20f0d..35d9741918 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -31,24 +31,6 @@ #include "sysemu/sysemu.h" #endif -//#define DEBUG_S390 -//#define DEBUG_S390_STDOUT - -#ifdef DEBUG_S390 -#ifdef DEBUG_S390_STDOUT -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, fmt, ## __VA_ARGS__); \ - if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) \ - do { qemu_log(fmt, ## __VA_ARGS__); } while (0) -#endif -#else -#define DPRINTF(fmt, ...) \ - do { } while (0) -#endif - - #ifndef CONFIG_USER_ONLY void s390x_tod_timer(void *opaque) {
It is not used anywhere. Signed-off-by: Cornelia Huck <cohuck@redhat.com> --- target/s390x/helper.c | 18 ------------------ 1 file changed, 18 deletions(-)