| Message ID | 20171113072715.3443-1-sw@weilnetz.de |
|---|---|
| State | New |
| Headers | show |
| Series | [for,2.12] disas/hppa: Fix compiler errors | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for 2.12] disas/hppa: Fix compiler errors
Type: series
Message-id: 20171113072715.3443-1-sw@weilnetz.de
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20171113072715.3443-1-sw@weilnetz.de -> patchew/20171113072715.3443-1-sw@weilnetz.de
Switched to a new branch 'test'
e0bbd4d71b disas/hppa: Fix compiler errors
=== OUTPUT BEGIN ===
Checking PATCH 1/1: disas/hppa: Fix compiler errors...
ERROR: suspect code indent for conditional statements (20, 22)
#23: FILE: disas/hppa.c:2701:
if (sign)
+ disp = (UINT_MAX << 10) | imm10;
ERROR: code indent should never use tabs
#25: FILE: disas/hppa.c:2702:
+^I^I disp = (UINT_MAX << 10) | imm10;$
ERROR: suspect code indent for conditional statements (20, 22)
#32: FILE: disas/hppa.c:2717:
if (sign)
+ disp = (UINT_MAX << 11) | imm11;
ERROR: code indent should never use tabs
#34: FILE: disas/hppa.c:2718:
+^I^I disp = (UINT_MAX << 11) | imm11;$
total: 4 errors, 0 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
diff --git a/disas/hppa.c b/disas/hppa.c index a2d371fdb1..0d1e99eab3 100644 --- a/disas/hppa.c +++ b/disas/hppa.c @@ -2699,7 +2699,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info) int disp; if (sign) - disp = (-1 << 10) | imm10; + disp = (UINT_MAX << 10) | imm10; else disp = imm10; @@ -2715,7 +2715,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info) int disp; if (sign) - disp = (-1 << 11) | imm11; + disp = (UINT_MAX << 11) | imm11; else disp = imm11;
gcc (Debian 6.3.0-18) 6.3.0 20170516 reports these errors: disas/hppa.c:2702:20: error: left shift of negative value [-Werror=shift-negative-value] disas/hppa.c:2718:20: error: left shift of negative value [-Werror=shift-negative-value] Signed-off-by: Stefan Weil <sw@weilnetz.de> --- This patch fails with checkpatch.pl because the code uses tab indention. disas/hppa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)