| Message ID | 20170711185511.3033-1-f4bug@amsat.org |
|---|---|
| State | Changes Requested |
| Headers | show |
On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > same as Thomas previous patch. this file had no entry in MAINTAINERS. > > atomic_template.h => accel/tcg/atomic_template.h | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename atomic_template.h => accel/tcg/atomic_template.h (100%) > > diff --git a/atomic_template.h b/accel/tcg/atomic_template.h > similarity index 100% > rename from atomic_template.h > rename to accel/tcg/atomic_template.h It's also used by a file in tcg/, but I've checked, and yes, the code still compiles fine if the header gets moved to accel/tcg/. Tested-by: Thomas Huth <thuth@redhat.com>
On 12/07/2017 07:52, Thomas Huth wrote: > On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> same as Thomas previous patch. this file had no entry in MAINTAINERS. >> >> atomic_template.h => accel/tcg/atomic_template.h | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >> >> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >> similarity index 100% >> rename from atomic_template.h >> rename to accel/tcg/atomic_template.h > > It's also used by a file in tcg/, but I've checked, and yes, the code > still compiles fine if the header gets moved to accel/tcg/. > > Tested-by: Thomas Huth <thuth@redhat.com> > That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, and user-exec.c should in turn be in accel/tcg. Since this is just code movement we can do it after soft freeze. Philippe, can you send v2? Thanks, Paolo
On 13.07.2017 13:35, Paolo Bonzini wrote: > On 12/07/2017 07:52, Thomas Huth wrote: >> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>> >>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>> 1 file changed, 0 insertions(+), 0 deletions(-) >>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>> >>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>> similarity index 100% >>> rename from atomic_template.h >>> rename to accel/tcg/atomic_template.h >> >> It's also used by a file in tcg/, but I've checked, and yes, the code >> still compiles fine if the header gets moved to accel/tcg/. >> >> Tested-by: Thomas Huth <thuth@redhat.com> >> > > That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, > and user-exec.c should in turn be in accel/tcg. > > Since this is just code movement we can do it after soft freeze. > Philippe, can you send v2? Ping? Looks like the atomic_template.h is still in the main directory ... Thomas
On 07/09/2017 11:30, Thomas Huth wrote: > On 13.07.2017 13:35, Paolo Bonzini wrote: >> On 12/07/2017 07:52, Thomas Huth wrote: >>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>>> >>>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>>> >>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>>> similarity index 100% >>>> rename from atomic_template.h >>>> rename to accel/tcg/atomic_template.h >>> >>> It's also used by a file in tcg/, but I've checked, and yes, the code >>> still compiles fine if the header gets moved to accel/tcg/. >>> >>> Tested-by: Thomas Huth <thuth@redhat.com> >>> >> >> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, >> and user-exec.c should in turn be in accel/tcg. >> >> Since this is just code movement we can do it after soft freeze. >> Philippe, can you send v2? > > Ping? > > Looks like the atomic_template.h is still in the main directory ... Still waiting for v2... Paolo
>>>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>> --- >>>>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>>>> >>>>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>>>> >>>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>>>> similarity index 100% >>>>> rename from atomic_template.h >>>>> rename to accel/tcg/atomic_template.h >>>> >>>> It's also used by a file in tcg/, but I've checked, and yes, the code >>>> still compiles fine if the header gets moved to accel/tcg/. >>>> >>>> Tested-by: Thomas Huth <thuth@redhat.com> >>>> >>> >>> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, >>> and user-exec.c should in turn be in accel/tcg. >>> >>> Since this is just code movement we can do it after soft freeze. >>> Philippe, can you send v2? >> >> Ping? >> >> Looks like the atomic_template.h is still in the main directory ... > > Still waiting for v2... I chat with Thomas last night about it, with 2.10 freeze I totally forgot about this, sorry! I'll respin v2 during the day.
diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
similarity index 100%
rename from atomic_template.h
rename to accel/tcg/atomic_template.h
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- same as Thomas previous patch. this file had no entry in MAINTAINERS. atomic_template.h => accel/tcg/atomic_template.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename atomic_template.h => accel/tcg/atomic_template.h (100%)