From patchwork Thu Jun 29 01:02:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 781982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wyhMJ4Nmsz9s75 for ; Thu, 29 Jun 2017 11:06:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SKWtw9yk"; dkim-atps=neutral Received: from localhost ([::1]:36327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQNuz-0006me-W2 for incoming@patchwork.ozlabs.org; Wed, 28 Jun 2017 21:06:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQNrl-0004Fd-9o for qemu-devel@nongnu.org; Wed, 28 Jun 2017 21:03:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQNrk-00071N-Dg for qemu-devel@nongnu.org; Wed, 28 Jun 2017 21:03:29 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:35048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQNrk-00071B-9q for qemu-devel@nongnu.org; Wed, 28 Jun 2017 21:03:28 -0400 Received: by mail-qk0-x242.google.com with SMTP id 16so9865860qkg.2 for ; Wed, 28 Jun 2017 18:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wiqiA5OtkpOsCZvIL+KzhOqcaDVWaNHAFfcITaqSRUk=; b=SKWtw9ykF3MjEIZ5O+XTfjt2ke6jtmglcmXo9eHn2Y0lf1S4m1gGXEDU/AxweRjp3L yt0S6uw+TuRFcQ1IEgB4TvYBF+34f0rHxgMzboGbpSlYfP5g7mEis4f6ty7hBUhc19nl shcqQ1AcNfxHfpyD0isn17eFLQAO6TpDx7OLHEaF9/L2a5CeOXl/1jSvATLxg2X9l8zG R+MKUQDO8wzhFCQ3ax/u5Xiccs5rRyHQ5t1vyGpd5x1qzg35675pRHqndVpAglXnWrm7 wJicjqqjgFhucCre313FLgKTZyFgQUhSe1tn/VqzIvZ0GTMUfThIj6edQjd+UH5zrla7 yx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wiqiA5OtkpOsCZvIL+KzhOqcaDVWaNHAFfcITaqSRUk=; b=EqbOd6vw3jKA6IErBWZVOt7XN8yafLazU57QAImEbm4Cvzy6SnOrggTOALJovoPN5P e0Y5Q0zMc2s6tFVJf2yUuZ0+WsSy43b11QTAVR2L5FfZq/E3C2j9TTjYaBCGlTupTrX0 KYG+DVW4fELlntDgCfV3E4zKAMbnOtfmqmVhtyS1VYn5hdRf6AFS/Gq1rLDg1xDyD0p7 sIyg0lIVXrUSvpt5quN0gJPRyH+LawDT3nHUfSw6qGAYA0epotwU3SBmxbb1jxJRSKTK pkRixXLnNTbOtQk4ug+OryTql9kJad0g50xrEAJGT4X7kkEW9TXiwtdIegIjrFe76Nwz fhgw== X-Gm-Message-State: AKS2vOzuW3tHUsAIbDOJf677HYDCAuj3kW0jerayjeVfCBr4Cr6ZOvjc VQRXve/NANFjVukbMVM= X-Received: by 10.55.195.6 with SMTP id a6mr16600899qkj.114.1498698207501; Wed, 28 Jun 2017 18:03:27 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id b195sm3014644qka.20.2017.06.28.18.03.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 18:03:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Emilio G . Cota" , Stefan Weil Date: Wed, 28 Jun 2017 22:02:57 -0300 Message-Id: <20170629010300.2848-6-f4bug@amsat.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170629010300.2848-1-f4bug@amsat.org> References: <20170629010300.2848-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" remove some copy/paste leftover, code seems sane. while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffffffc00036cd04] ---------------- IN: 0xffffffc00036cd24: 5ac00694 rev16 w20, w20 OP: ---- ffffffc00036cd24 0000000000000000 0000000000000000 ext32u_i64 tmp3,x20 ext16u_i64 tmp2,tmp3 bswap16_i64 x20,tmp2 movi_i64 tmp4,$0x10 shr_i64 tmp2,tmp3,tmp4 ext16u_i64 tmp2,tmp2 bswap16_i64 tmp2,tmp2 deposit_i64 x20,x20,tmp2,$0x10,$0x10 Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24] Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24] TODO qemu/tci.c:1049: tcg_qemu_tb_exec() qemu/tci.c:1049: tcg fatal error Aborted Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Weil --- tcg/tci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 4bdc645f2a..f39bfb95c0 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) break; #if TCG_TARGET_HAS_bswap16_i64 case INDEX_op_bswap16_i64: - TODO(); t0 = *tb_ptr++; t1 = tci_read_r16(&tb_ptr); tci_write_reg64(t0, bswap16(t1));