From patchwork Fri Jun 23 16:45:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 780225 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wvQkm4Nhpz9s8P for ; Sat, 24 Jun 2017 03:42:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TgLCo6/3"; dkim-atps=neutral Received: from localhost ([::1]:36715 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOSb6-0000z8-TY for incoming@patchwork.ozlabs.org; Fri, 23 Jun 2017 13:42:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dORjH-00081P-Fh for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dORjG-0002Uq-OG for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:43 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:36283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dORjG-0002Uk-K3 for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:42 -0400 Received: by mail-qt0-x242.google.com with SMTP id v31so2026302qtb.3 for ; Fri, 23 Jun 2017 09:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QDrd9WkeZruOUaX/2nTP/dS1GuFHJ3z2iub0Nj3Z/HU=; b=TgLCo6/3URF9TAGlUysAQIghUrTOyuofkxAi1/4fotftVHgmp5asW70efmUUMR5+48 dDFGig+2WUJE4VB7EWjOAhjVka0iSwgq8QAJ1+yKm2oaCYLwuOCWs8eniRqP8lskh3Db DuYCxNw+8M17/A/hWlV/k0etPDfMtjkl5D1VrUZXyj5kr8Ktyf2r+A4cm3+m29ffK2ja Agcu/SvbBoTXVItUlyGN8oFmwy61PZu0sTDV3QD27zO8uBshCH0AOR06UEHhxuqwMi2S 0IB5r5pvGq+mgV9x8gb7bZLbS9xB0+0hFETRShORyxlyUhaI2iobFJiJEDZgsFec2M96 c2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QDrd9WkeZruOUaX/2nTP/dS1GuFHJ3z2iub0Nj3Z/HU=; b=e8CWCsrDJPICII8aGHkB/P6e4BnyhuMN13+I/5v1TkdUhfMCBFAG2j6Qk1DpbddmkK Qr1JiNwiM4qQ7UULPJ+l6gNRJufFe7uhCqXYEXqU5zB9AUtZ5/zDPYMm1MoSuF8sQiJn uDpg8bwq+wr1XHrl2g13YOLw6CLcktzpTF7ggZhGYjP9Ot6+8sPwQQLx42rJDva3KU0X UEe/VnHTHe+HXNIc+9M0BYexAzYM6Vu+eIfgwnfZdJHX4t7lZr3CBBvxIvszinNpwsoh dcJqCJUoq3ParigDTw1iLXv6B3iLnN/b7KHeht+p/csn0YuK/IR9gEnhsFeJtS4DZz2z PZmQ== X-Gm-Message-State: AKS2vOxRNwsdr9dbvX8CNhcMLYrYp1+3CbkUq8ejr87OABplsrarH7Hi msZoVKHLyogFMVOaAFJZ7w== X-Received: by 10.200.41.138 with SMTP id 10mr10036567qts.85.1498236401987; Fri, 23 Jun 2017 09:46:41 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id x7sm3690803qkx.45.2017.06.23.09.46.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 09:46:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Eric Blake , Peter Crosthwaite , Markus Armbruster , Laszlo Ersek , "Michael S . Tsirkin" , Gerd Hoffmann , Alexander Graf , David Gibson , Eduardo Habkost Date: Fri, 23 Jun 2017 13:45:57 -0300 Message-Id: <20170623164557.11636-4-f4bug@amsat.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623164557.11636-1-f4bug@amsat.org> References: <20170623164557.11636-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH 3/3] hw/core: report an error if invalid gpio is used X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" then abort calling error_setg() Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/core/qdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 849952a8d4..05aaa67cb8 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -448,7 +448,11 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n) { NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name); - assert(n >= 0 && n < gpio_list->num_in); + assert(n >= 0); + if (n >= gpio_list->num_in) { + error_setg(&error_abort, "Invalid gpio #%d (of %d) for %s", + n, gpio_list->num_in, name ? name : "device"); + } return gpio_list->in[n]; }