From patchwork Fri May 12 23:38:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 761892 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wPmpc1qyZz9s7w for ; Sat, 13 May 2017 09:46:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KrXTe7MB"; dkim-atps=neutral Received: from localhost ([::1]:55714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9KGj-0006ib-TQ for incoming@patchwork.ozlabs.org; Fri, 12 May 2017 19:46:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9K9R-0000AX-2O for qemu-devel@nongnu.org; Fri, 12 May 2017 19:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9K9Q-0002m9-78 for qemu-devel@nongnu.org; Fri, 12 May 2017 19:39:13 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:33969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9K9Q-0002lB-3R for qemu-devel@nongnu.org; Fri, 12 May 2017 19:39:12 -0400 Received: by mail-qt0-x244.google.com with SMTP id l39so8698598qtb.1 for ; Fri, 12 May 2017 16:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1bkRuEvz2MpJYn1Dl4J2BPFGfTgIVrdJ8nOn3hpgo/s=; b=KrXTe7MB49yqL4RjOlHhxNFj+eirlpYWHnoXY6bPX+6PqueQ7Yb6KSeXumhFwcKdUs iuuXODwlJmpGvivzvLddumg/I1OiUIf9MYHzOambXqu/jWB2RaS7G7rtdI2Ypr2BPbwi CD89ci7FwqeZDS72VXSCSZ1xVl9Ey2ve5HyIRHkxmvcIGsbvqwzB5jOZOoJoTUgfnCYZ WWh0Ya45nt259TV4j4/8O14lzmrvPNysJDd4VNYt8VqXbKnesCTUl/Cp2KhgqFWhM0H8 7AxaPiY9Fc7AptIwzq4rMMDZLWH6k6DzokkHNiZFN+e4CUNhfAIrw/pG94eydPouWQ66 mCDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1bkRuEvz2MpJYn1Dl4J2BPFGfTgIVrdJ8nOn3hpgo/s=; b=BoWhjTgEwG+00+tXpvk81u/zdD3dHGTlq/u+qnYSNC07n9Ls5EUnwuvNj5Fny02JU1 5DJJncDFiTW8L8ThDOc55PQx+wfQFW5vHCiTQJgbu9+ME5zdezgr2ZiMxrHa3whs0aEc lgLDE95Z4HdB6r0qcoMxjryLEKqKb+xOX/X12jJ9VmjPJalLi+bA0zDE3bBhaW0cloWV +gAbj3MWJ7aCYCOc3r7Wq4JTsA0w+LQ60gC3UY4mJHjR2VCfMOoUsaEGrPdv0djo0TVd bwIy4jCQ89XI3fwxVVjRR/gbS2sIzSvrwwYPEer6eicwA1yGjMFKkwgE+WMAfpEBj0aN 5y8g== X-Gm-Message-State: AODbwcBq9QNtfnT8pF7Cxqnh4y3VhuJJQ/JUHQGLNdsa2hGie3qXpD+Y eyTRLXCvQeo2Sw== X-Received: by 10.237.61.28 with SMTP id g28mr6063300qtf.279.1494632351574; Fri, 12 May 2017 16:39:11 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id n78sm3253857qki.60.2017.05.12.16.39.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 May 2017 16:39:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Mark Cave-Ayland , Artyom Tarasenko Date: Fri, 12 May 2017 20:38:43 -0300 Message-Id: <20170512233843.27713-7-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512233843.27713-1-f4bug@amsat.org> References: <20170512233843.27713-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/sparc/translate.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index aa6734d54e..67a83b77cc 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -380,29 +380,25 @@ static inline void gen_goto_tb(DisasContext *s, int tb_num, static inline void gen_mov_reg_N(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_NEG_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_NEG_SHIFT, 1); } static inline void gen_mov_reg_Z(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_ZERO_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_ZERO_SHIFT, 1); } static inline void gen_mov_reg_V(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_OVF_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_OVF_SHIFT, 1); } static inline void gen_mov_reg_C(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_CARRY_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_CARRY_SHIFT, 1); } static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, TCGv src2) // env->y = (b2 << 31) | (env->y >> 1); tcg_gen_andi_tl(r_temp, cpu_cc_src, 0x1); tcg_gen_shli_tl(r_temp, r_temp, 31); - tcg_gen_shri_tl(t0, cpu_y, 1); - tcg_gen_andi_tl(t0, t0, 0x7fffffff); + tcg_gen_extract_tl(t0, cpu_y, 1, 31); tcg_gen_or_tl(t0, t0, r_temp); tcg_gen_andi_tl(cpu_y, t0, 0xffffffff);