From patchwork Sat May 6 00:41:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 759246 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wKVMW0RKyz9s80 for ; Sat, 6 May 2017 10:41:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d37qC1mt"; dkim-atps=neutral Received: from localhost ([::1]:49560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6nnG-0004Wn-MW for incoming@patchwork.ozlabs.org; Fri, 05 May 2017 20:41:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6nmp-0004SN-J6 for qemu-devel@nongnu.org; Fri, 05 May 2017 20:41:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6nmo-00038F-O7 for qemu-devel@nongnu.org; Fri, 05 May 2017 20:41:27 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:34958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6nmk-0002z4-E6; Fri, 05 May 2017 20:41:22 -0400 Received: by mail-qt0-x244.google.com with SMTP id r58so2906175qtb.2; Fri, 05 May 2017 17:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wk+ZwY/w7oX323eqXLrNQVzxKBSjRzTX0Y3KlsdeX8Q=; b=d37qC1mtTSQ7eze4alSRn+UNu8DcLkdLWVZ22EO8jw8T0c3N5xZUROOTuatP1Da6OQ 79sRlBXY1MUASpLCRfxeIo8PKmXj08UiacSiUUSvzUYZg0JEdICi4xasQDWX1sH/P5ZP whFqI03P/uKr2KUMpiG7L8SOV2WWX3SfdVpI05V6fdPpnhZ8GrtjAtVvUTwanLglETUZ VAmPSCtJ7/JruScAT3lwNfAEG/A74ogWl9koVLIzz9Uu3tWLvIBHptL4vfjkPncjZruh Ltu2FJQw2gFuIxBZGg2X80XLOCimlJ93y7R/fmyrVcwu8C3n5WiquiAwY+NMQT+1FHkW mO4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=wk+ZwY/w7oX323eqXLrNQVzxKBSjRzTX0Y3KlsdeX8Q=; b=Vl86HLq0ob0vRc6z3m9bc7+5qhPIJIy6fGiq6JZgloU/u/Hac0blpYukx98F8oWONm jTJy8lkVUAWv9a1tbg/Y3IOaTngVG30lYGE2hVeyf1j+jpCn9Ntq95cpHVjK/NTk+Md8 oBL0GjsrwIvqpKZaWJH8c4uMofToO+tRZsoRK+oP1MglU59QkhYne7RrJ1vKS+iqHokp Tkvi2Yche2qsjIWhgHK2j5zB49FSracjImyX40TP1c7douUp7nWIV6FTPNXrc4zZloC3 gyyUYY0hcaAymB1DOzZ+A44tjA017IM8HQ3oC02j8L7PZq4TgNmNHi76P2yWDBu0RT1q seGg== X-Gm-Message-State: AN3rC/7qLc5FHkpvyS6oip431qjQmcWuDSJNgVcIrKudobfwHHksBs3P A0IeLkCOd1SPbg== X-Received: by 10.237.56.135 with SMTP id k7mr9886061qte.121.1494031281456; Fri, 05 May 2017 17:41:21 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id r19sm4471745qkl.54.2017.05.05.17.41.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 17:41:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Riku Voipio Date: Fri, 5 May 2017 21:41:06 -0300 Message-Id: <20170506004106.3291-1-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" static code analyzer complain: linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr != 0) { ^~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index cec8428589..c541e22693 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5526,7 +5526,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp, int target_size; void *argptr; abi_ulong *target_rt_dev_ptr; - unsigned long *host_rt_dev_ptr; + unsigned long *host_rt_dev_ptr = NULL; abi_long ret; int i; @@ -5572,7 +5572,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp, unlock_user(argptr, arg, 0); ret = get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); - if (*host_rt_dev_ptr != 0) { + if (host_rt_dev_ptr != NULL && *host_rt_dev_ptr != 0) { unlock_user((void *)*host_rt_dev_ptr, *target_rt_dev_ptr, 0); }