| Message ID | 20170118150235.23850-1-bobby.prani@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 18 January 2017 at 15:02, Pranith Kumar <bobby.prani@gmail.com> wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > old_value is the 4th argument of timer_settime(), not the 2nd. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 7b77503f94..5bd477a71b 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -12027,7 +12027,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, > target_to_host_itimerspec(&hspec_new, arg3); > ret = get_errno( > timer_settime(htimer, arg2, &hspec_new, &hspec_old)); > - host_to_target_itimerspec(arg2, &hspec_old); > + host_to_target_itimerspec(arg4, &hspec_old); > } > break; > } > -- > 2.11.0 I reviewed this when Marc sent it back in November, but this resend doesn't seem to have addressed any of that. thanks -- PMM
On Wed, Jan 18, 2017 at 11:20 AM, Peter Maydell <peter.maydell@linaro.org> wrote: > > I reviewed this when Marc sent it back in November, > but this resend doesn't seem to have addressed any > of that. > Sorry about that. I seem to have missed the reviews last time. I'll update and resend them. Thanks,
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7b77503f94..5bd477a71b 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -12027,7 +12027,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, target_to_host_itimerspec(&hspec_new, arg3); ret = get_errno( timer_settime(htimer, arg2, &hspec_new, &hspec_old)); - host_to_target_itimerspec(arg2, &hspec_old); + host_to_target_itimerspec(arg4, &hspec_old); } break; }