Message ID | 20140910143413.6908.43083.stgit@PASHA-ISP |
---|---|
State | New |
Headers | show |
Il 10/09/2014 16:34, Pavel Dovgalyuk ha scritto: > This patch initializes monitor for gdbstub with the qemu_chr_alloc function > instead of just allocating the memory. Initialization function call > is required, because it also creates chr_write_lock mutex, which is used > when writing to this character device. > > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru> > --- > gdbstub.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 8afe0b7..71aaa23 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1707,7 +1707,7 @@ int gdbserver_start(const char *device) > qemu_add_vm_change_state_handler(gdb_vm_state_change, NULL); > > /* Initialize a monitor terminal for gdb */ > - mon_chr = g_malloc0(sizeof(*mon_chr)); > + mon_chr = qemu_chr_alloc(); > mon_chr->chr_write = gdb_monitor_write; > monitor_init(mon_chr, 0); > } else { > Thanks, will send a pull request soon. Paolo
diff --git a/gdbstub.c b/gdbstub.c index 8afe0b7..71aaa23 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1707,7 +1707,7 @@ int gdbserver_start(const char *device) qemu_add_vm_change_state_handler(gdb_vm_state_change, NULL); /* Initialize a monitor terminal for gdb */ - mon_chr = g_malloc0(sizeof(*mon_chr)); + mon_chr = qemu_chr_alloc(); mon_chr->chr_write = gdb_monitor_write; monitor_init(mon_chr, 0); } else {
This patch initializes monitor for gdbstub with the qemu_chr_alloc function instead of just allocating the memory. Initialization function call is required, because it also creates chr_write_lock mutex, which is used when writing to this character device. Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru> --- gdbstub.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)