From patchwork Thu Jan 20 12:33:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Bharadwaj X-Patchwork-Id: 79681 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DD648B70D5 for ; Thu, 20 Jan 2011 23:42:53 +1100 (EST) Received: from localhost ([127.0.0.1]:54563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pftpo-0005Tk-Jn for incoming@patchwork.ozlabs.org; Thu, 20 Jan 2011 07:41:52 -0500 Received: from [140.186.70.92] (port=45418 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pfti1-0001Kt-Sx for qemu-devel@nongnu.org; Thu, 20 Jan 2011 07:33:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pfti0-0002gQ-NC for qemu-devel@nongnu.org; Thu, 20 Jan 2011 07:33:49 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:37296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pfti0-0002gF-5H for qemu-devel@nongnu.org; Thu, 20 Jan 2011 07:33:48 -0500 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id p0KCXiO0027084 for ; Thu, 20 Jan 2011 23:33:44 +1100 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0KCXisq1355872 for ; Thu, 20 Jan 2011 23:33:44 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0KCXiYm009944 for ; Thu, 20 Jan 2011 23:33:44 +1100 Received: from localhost6.localdomain6 (Crystal-Planet.in.ibm.com [9.124.35.20]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p0KCXgX2009939; Thu, 20 Jan 2011 23:33:43 +1100 To: qemu-devel@nongnu.org From: Arun R Bharadwaj Date: Thu, 20 Jan 2011 18:03:41 +0530 Message-ID: <20110120123341.17667.45861.stgit@localhost6.localdomain6> In-Reply-To: <20110120123236.17667.66688.stgit@localhost6.localdomain6> References: <20110120123236.17667.66688.stgit@localhost6.localdomain6> User-Agent: StGit/0.15 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: kwolf@redhat.com, aliguori@linux.vnet.ibm.com, jvrao@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 05/12] Threadlet: Add submit_work threadlet API. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch adds submit work threadlet API and shows how the qemu_paio_submit changes to submit_work. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 33 ++++++++++++++++++++++----------- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 011633f..62e32e3 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -393,13 +393,13 @@ static void spawn_threadlet(ThreadletQueue *queue) if (sigprocmask(SIG_SETMASK, &oldset, NULL)) die("sigprocmask restore"); } -static void qemu_paio_submit(struct qemu_paiocb *aiocb) +/** + * submit_work: Submit to the global queue a new task to be executed + * asynchronously. + * @work: Contains information about the task that needs to be submitted. + */ +static void submit_work(ThreadletWork *work) { - qemu_mutex_lock(&aiocb_mutex); - aiocb->ret = -EINPROGRESS; - aiocb->active = 0; - qemu_mutex_unlock(&aiocb_mutex); - qemu_mutex_lock(&globalqueue.lock); if (!globalqueue_init) { @@ -415,13 +415,13 @@ static void qemu_paio_submit(struct qemu_paiocb *aiocb) } if (globalqueue.idle_threads == 0 && - globalqueue.cur_threads < globalqueue.max_threads) + globalqueue.cur_threads < globalqueue.max_threads) { spawn_threadlet(&globalqueue); - aiocb->work.func = handle_work; - - QTAILQ_INSERT_TAIL(&globalqueue.request_list, &aiocb->work, node); - qemu_cond_signal(&globalqueue.cond); + } else { + qemu_cond_signal(&globalqueue.cond); + } + QTAILQ_INSERT_TAIL(&globalqueue.request_list, work, node); qemu_mutex_unlock(&globalqueue.lock); } @@ -448,6 +448,17 @@ static int qemu_paio_error(struct qemu_paiocb *aiocb) return ret; } +static void qemu_paio_submit(struct qemu_paiocb *aiocb) +{ + qemu_mutex_lock(&aiocb_mutex); + aiocb->ret = -EINPROGRESS; + aiocb->active = 0; + qemu_mutex_unlock(&aiocb_mutex); + + aiocb->work.func = handle_work; + submit_work(&aiocb->work); +} + static int posix_aio_process_queue(void *opaque) { PosixAioState *s = opaque;