From patchwork Wed Mar 31 15:42:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahar Havivi X-Patchwork-Id: 49162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 05948B7CF9 for ; Thu, 1 Apr 2010 02:58:32 +1100 (EST) Received: from localhost ([127.0.0.1]:46778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nx0I1-0001g8-JH for incoming@patchwork.ozlabs.org; Wed, 31 Mar 2010 11:57:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nx05F-0005c2-Aq for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:43:57 -0400 Received: from [140.186.70.92] (port=49879 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nx05D-0005ao-Mi for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nx05A-0007Er-ML for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:43:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24444) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nx05A-0007Ej-8N for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:43:52 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VFhow0021852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Mar 2010 11:43:50 -0400 Received: from localhost (dhcp-1-229.tlv.redhat.com [10.35.1.229]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2VFhnsA012047; Wed, 31 Mar 2010 11:43:50 -0400 Date: Wed, 31 Mar 2010 18:42:42 +0300 From: Shahar Havivi To: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' Message-ID: <20100331154242.GB15365@redhat.com> References: <689f24e27d483de0e3201a9386c772dc241d4178.1270022701.git.shaharh@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org, Juan Quintela X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Wed, Mar 31, 2010 at 05:31:49PM +0200, Markus Armbruster wrote: > Date: Wed, 31 Mar 2010 17:31:49 +0200 > From: Markus Armbruster > To: Juan Quintela > Cc: Shahar Havivi , qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: > 'keyboard_set' and 'info keybaord' > > Juan Quintela writes: > > > Shahar Havivi wrote: > >> Two new monitor commands: adding ability to handle which keyboard qemu will > >> use and to see which keyboard are currently available. > > > >> +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data) > >> +{ > >> + QEMUPutKbdEntry *cursor; > >> + int index = qdict_get_int(qdict, "index"); > >> + int found = 0; > > > > found variable is not used. > > > >> + > >> + if (QTAILQ_EMPTY(&kbd_handlers)) { > >> + qerror_report(QERR_DEVICE_NOT_FOUND, "keyboard"); > >> + return -1; > >> + } > >> + > >> + QTAILQ_FOREACH(cursor, &kbd_handlers, node) { > >> + if (cursor->index == index) { > >> + QTAILQ_REMOVE(&kbd_handlers, cursor, node); > >> + QTAILQ_INSERT_HEAD(&kbd_handlers, cursor, node); > >> + found = 1; > > > > well it is set :) > > > >> + break; > >> + } > >> + } > >> + > >> + return 0; > > > > I guess you want to return one error if the index don't exist. Right about that, Thanks. > >> +} > > > > I still think that adding an "id" property as in markus proposal would > > be neat. Otherwise I don't know how you are going to distinguish > > between two keyboards with the same name. > > If I understand the patch correctly (only time for a quick skim today), > the keyboard receives a numeric ID when it is created, and keyboard_set > identifies it by that ID. Yes, a user-defined ID would be nicer, and > consistent with how similar things work. But the numeric ID isn't > *wrong*, as far as I can see. The index Id that I use is the same as I saw that the mouse devices do, I will try to get it from the user as well (I guess you mean by command line: 'qemu -device usb-kbd,id=kbd ...') Signed-off-by: Shahar Havivi --- console.h | 4 ++ input.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ monitor.c | 8 ++++ qemu-monitor.hx | 17 +++++++++ 4 files changed, 135 insertions(+), 0 deletions(-) diff --git a/console.h b/console.h index 91b66ea..889f5d5 100644 --- a/console.h +++ b/console.h @@ -87,6 +87,10 @@ void do_info_mice_print(Monitor *mon, const QObject *data); void do_info_mice(Monitor *mon, QObject **ret_data); void do_mouse_set(Monitor *mon, const QDict *qdict); +void do_info_keyboard_print(Monitor *mon, const QObject *data); +void do_info_keyboard(Monitor *mon, QObject **ret_data); +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data); + /* keysym is a unicode code except for special keys (see QEMU_KEY_xxx constants) */ #define QEMU_KEY_ESC1(c) ((c) | 0xe100) diff --git a/input.c b/input.c index 18875a9..27ef8f9 100644 --- a/input.c +++ b/input.c @@ -329,3 +329,109 @@ void qemu_remove_mouse_mode_change_notifier(Notifier *notify) { notifier_list_remove(&mouse_mode_notifiers, notify); } + +static void info_keyboard_iter(QObject *data, void *opaque) +{ + QDict *kbd; + Monitor *mon = opaque; + + kbd = qobject_to_qdict(data); + monitor_printf(mon, "%c Keyboard #%" PRId64 ": %s\n", + (qdict_get_bool(kbd, "current") ? '*' : ' '), + qdict_get_int(kbd, "index"), qdict_get_str(kbd, "name")); +} + +void do_info_keyboard_print(Monitor *mon, const QObject *data) +{ + QList *kbd_list; + + kbd_list = qobject_to_qlist(data); + if (qlist_empty(kbd_list)) { + monitor_printf(mon, "No keyboard devices connected\n"); + return; + } + + qlist_iter(kbd_list, info_keyboard_iter, mon); +} + +/* + * do_info_keyboard(): Show VM keyboard information + * + * Each keyboard is represented by a QDict, the returned QObject is + * a QList of all keyboards. + * + * The keyboard QDict contains the following: + * + * - "name": keyboard's name + * - "index": keyboard's index + * - "current": true if this keyboard is receiving events, false otherwise + * + * Example: + * + * [ { "name": "QEMU USB Keyboard", "index": 0, "current": false }, + * { "name": "QEMU PS/2 Keyboard", "index": 1, "current": true } ] + */ +void do_info_keyboard(Monitor *mon, QObject **ret_data) +{ + QEMUPutKbdEntry *cursor; + QList *kbd_list; + int current; + + kbd_list = qlist_new(); + + if (QTAILQ_EMPTY(&kbd_handlers)) { + goto out; + } + + current = QTAILQ_FIRST(&kbd_handlers)->index; + QTAILQ_FOREACH(cursor, &kbd_handlers, node) { + QObject *obj; + obj = qobject_from_jsonf("{ 'name': %s," + " 'index': %d," + " 'current': %i }", + cursor->qemu_put_kbd_name, + cursor->index, + current == cursor->index); + qlist_append_obj(kbd_list, obj); + } +out: + *ret_data = QOBJECT(kbd_list); +} + +/* + * do_keyboard_set(): Set active keyboard + * + * Argument qdict contains + * - "index": the keyboard index to set + * + * Example: + * + * { "index": "0" } + */ +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data) +{ + QEMUPutKbdEntry *cursor; + int index = qdict_get_int(qdict, "index"); + int found = 0; + + if (QTAILQ_EMPTY(&kbd_handlers)) { + qerror_report(QERR_DEVICE_NOT_FOUND, "keyboard"); + return -1; + } + + QTAILQ_FOREACH(cursor, &kbd_handlers, node) { + if (cursor->index == index) { + QTAILQ_REMOVE(&kbd_handlers, cursor, node); + QTAILQ_INSERT_HEAD(&kbd_handlers, cursor, node); + found = 1; + break; + } + } + + if (!found) { + qerror_report(QERR_INVALID_PARAMETER, "index"); + return -1; + } + + return 0; +} diff --git a/monitor.c b/monitor.c index 822dc27..f5474b1 100644 --- a/monitor.c +++ b/monitor.c @@ -2781,6 +2781,14 @@ static const mon_cmd_t info_cmds[] = { .mhandler.info_new = do_info_mice, }, { + .name = "keyboard", + .args_type = "", + .params = "", + .help = "show which guest keyboard is receiving events", + .user_print = do_info_keyboard_print, + .mhandler.info_new = do_info_keyboard, + }, + { .name = "vnc", .args_type = "", .params = "", diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 5308f36..e9beb12 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -659,6 +659,23 @@ info mice @end example ETEXI + { + .name = "keyboard_set", + .args_type = "index:i", + .params = "index", + .help = "set which keyboard device receives events", + .mhandler.cmd_new = do_keyboard_set, + }, + +STEXI +@item keyboard_set @var{index} +@findex keyboard_set +Set which keyboard device receives events at given @var{index}, index +can be obtained with +@example +info keyboard +@end example +ETEXI #ifdef HAS_AUDIO { .name = "wavcapture",